Closed Bug 1596990 Opened 5 months ago Closed 4 months ago

Tooltip "Manage Plug-in use" would not pop up when mouse hover over plug-in icon in Address Bar

Categories

(Firefox :: Address Bar, defect)

72 Branch
Desktop
Windows 10
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 --- verified

People

(Reporter: alice0775, Assigned: bdahl)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Reproducible: 100%

Steps to reproduce:

  1. Open web page that contains Flash
    e.g, https://helpx.adobe.com/flash-player.html
  2. Mouse hover over plugin icon in Address Bar

Actual Results:
No tooltip

Expected Results:
Tooltip "Manage Plug-in use" should display

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=038ebfdd141acdc7603d2378a832a572bb267686&tochange=9644ee96a51a03a8f4e50e9777fb7278f246383c

Flags: needinfo?(bdahl)
Assignee: nobody → bdahl
Flags: needinfo?(bdahl)

In pages with root <html> elements we always use the ToolTipTextProvider,
which surfaced a bug in it's implementation for XUL elements.
XUL element's getAttribute returns an empty string even if the attribute
doesn't exist. This caused the ToolTipTextProvider to stop its search
early for the actual tooltip text.

Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1dd6e40e77e
Fix tooltips for XUL elements in pages with <html> roots. r=mossop
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Regressions: 1598841
No longer regressions: 1598841
Flags: qe-verify+

Confirmed issue with 72.0a1 (2019-11-15) on Windows 10.
Fix verified with 72.0b15.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.