1597014 - Unify PDocumentChannel::RedirectToRealChannel and PContent::CrossProcessRedirect

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Matt Woodrow (:mattwoodrow)]

These two functions have a lot of arguments that are largely the same, and mainly only differ where one is missing functionality.

They also return slightly different values, so we have to have separate promise handlers for each.

I want to create a struct for all the args, make them return the same values, and then combine the promise handling in DocumentChannelParent so that we only have one.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1597014 - Unify same-process and cross-process redirect to real channel functions to avoid needed separate promise handlers. r?mayhemer

These two functions both have a large number of arguments that are largely identical (and ones missing from the PContent one are mostly oversights).
Unifying both to take a single argument and return the same result means we can unify the serialization and return value (promise) handling.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e10266c897
Unify same-process and cross-process redirect to real channel functions to avoid needed separate promise handlers. r=mayhemer

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/09e10266c897