Closed Bug 1597066 Opened 5 years ago Closed 5 years ago

Bookmarks Manager lacks styling

Categories

(SeaMonkey :: Themes, defect)

Product:
SeaMonkey
Component:
Themes
Version:
SeaMonkey 2.53 Branch
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.69
Tracking Flags:
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: stefanh, Assigned: frg)

References

(Regression)

Details

(Whiteboard: SM2.53.1)

Attachments

(3 files, 1 obsolete file)

1597066-organizer.patch
2.65 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
1597066-2-tests.patch
8.30 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-release+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review
1597066-3-tests2.patch
11.57 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-release+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

bookmarksManager.xul used "chrome://communicator/skin/bookmarks/bookmarksManager.css". After bug 1378089, places.xul doesn't use "chrome://communicator/skin/places/places.css".

One effect of this is that the 2.53.1 Bookmarks Manager lacks vibrancy in the placesList tree.

The file should have been renamed to organizer.css.

Assignee: nobody → frgrahl
Status: NEW → ASSIGNED

OK, but note that there's a bunch of tests refers to chrome://communicator/skin/places/places.css in comm-release.

Summary: Bookmarks Manager lacks styling (places.css not used by places.xul) → Bookmarks Manager lacks styling

Renamed and tested with 2.53.1. This looks ok now but might need further cleanups.
r/a from IanN over irc for the rename.

Attachment #9109248 - Flags: review+
Attachment #9109248 - Flags: approval-comm-release+
Attachment #9109248 - Flags: approval-comm-esr60+

OK, but note that there's a bunch of tests refers to chrome://communicator/skin/places/places.css in comm-release.
The tests are unfortunately all bad right now. Thex use other obsolete files too and were not adopted to the new async api. :( If we ever manage to fix this the ones from Firefox shouldprobably be used as a new base.

Forget what I wrote earlier :) places.css in the affected test files is the only wrong/missing file so fix it.

Attachment #9109269 - Flags: review?(iann_bugzilla)
Attachment #9109269 - Flags: approval-comm-release?
Attachment #9109269 - Flags: approval-comm-esr60?
Comment on attachment 9109269 [details] [diff] [review]
1597066-2-tests.patch

[Triage Comment]
LGTM r/a=me
Attachment #9109269 - Flags: review?(iann_bugzilla)
Attachment #9109269 - Flags: review+
Attachment #9109269 - Flags: approval-comm-release?
Attachment #9109269 - Flags: approval-comm-release+
Attachment #9109269 - Flags: approval-comm-esr60?
Attachment #9109269 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8bca8d96f154
Fix missing organizer.css on macOS. r=IanN
https://hg.mozilla.org/comm-central/rev/a0fa0fb92d75
Part 2. Fix missing organizer.css in suite tests. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attached patch 1597066-3-tests2.patch (obsolete) — — Splinter Review

Former 1378089-part-test-bookmarks-253.patch. Was never approved or checked in. rebased for current trees and filename typo corrected.

Attachment #9109942 - Flags: review?(iann_bugzilla)
Attachment #9109942 - Flags: approval-comm-release?
Attachment #9109942 - Flags: approval-comm-esr60?
Comment on attachment 9109942 [details] [diff] [review]
1597066-3-tests2.patch

Missed one. Stay tuned
Attachment #9109942 - Flags: review?(iann_bugzilla)
Attachment #9109942 - Flags: approval-comm-release?
Attachment #9109942 - Flags: approval-comm-esr60?

Should be all now.

Attachment #9109942 - Attachment is obsolete: true
Attachment #9109952 - Flags: review?(iann_bugzilla)
Attachment #9109952 - Flags: approval-comm-release?
Attachment #9109952 - Flags: approval-comm-esr60?
Comment on attachment 9109952 [details] [diff] [review]
1597066-3-tests2.patch

[Triage Comment]
LGTM r/a=me
Attachment #9109952 - Flags: review?(iann_bugzilla)
Attachment #9109952 - Flags: review+
Attachment #9109952 - Flags: approval-comm-release?
Attachment #9109952 - Flags: approval-comm-release+
Attachment #9109952 - Flags: approval-comm-esr60?
Attachment #9109952 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7d9bc05f93c7
Part 3. Correct location for places style and overlay files in tests. r=IanN

https://hg.mozilla.org/releases/comm-esr60/rev/6da61e3c73363084132c31e4c0d63b63c0530a29
Fix missing organizer.css on macOS. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/0ad38cff04c455af45516175abb4f45c40e0de39
Part 2. Fix missing organizer.css in suite tests. r=IanN a=IanN CLOSED TREE
https://hg.mozilla.org/releases/comm-esr60/rev/232db96d678a8360116d6f2d2f956432ea6a9ab7
Part 3. Correct location for places style and overlay files in tests. r=IanN a=IanN CLOSED TREE

status-seamonkey2.57esr: affected → fixed
Target Milestone: --- → seamonkey2.69
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: