Closed Bug 1597129 Opened 4 years ago Closed 4 years ago

mach addtest rewrites the entire manifest file with Windows line-endings when run on Windows.

Categories

(Firefox Build System :: Mach Core, defect)

Product:
Firefox Build System
Component:
Mach Core
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1597129 - fix newline usage for manifest writing in mach addtest, r?ahal
47 bytes, text/x-phabricator-request
Details | Review

STR:

  1. check out current m-c on Windows
  2. run ./mach addtest browser/base/content/test/plugins/browser_some_test_name.js
  3. run hg diff browser/base/content/test/plugins/browser.ini

ER:
one line addition

AR:
this: https://phabricator.services.mozilla.com/D53351?vs=on&id=193250#inline-323355

Summary: mach addtest messes with line-endings in the manifest file on Windows → mach addtest rewrites the entire manifest file with Windows line-endings when run on Windows.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7f64e4879257
fix newline usage for manifest writing in mach addtest, r=ahal

https://hg.mozilla.org/mozilla-central/rev/7f64e4879257

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
See Also: → 1610331
You need to log in before you can comment on or make changes to this bug.