Saved addresses settings dialog buttons are hidden
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox70 | --- | unaffected |
| firefox71 | --- | unaffected |
| firefox72 | --- | verified |
People
(Reporter: dekeltal, Assigned: bgrins)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
2019-11-18 12_08_04-Options - Firefox Nightly.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
Open settings > Privacy & Security > Forms and Autofill > Saved Addresses
Actual results:
Popup is too small, the buttons at the bottom are hidden. There's no scroll bar in this window. The only way to reach the buttons is to resize the window dragging from the bottom right corner.
Expected results:
Popup should be the right size to show all its contents. In extreme cases where it's not possible, at least it should have a scroll bar.
|
||
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
||
Comment 2•4 years ago
•
|
||
The first bad revision is:
changeset: 591369:1f37c31422e2
user: Kirk Steuber <ksteuber@mozilla.com>
date: Thu Nov 14 00:17:01 2019 +0000
summary: Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
|
|
||
Comment 3•4 years ago
|
||
This isn't disastrous because of the grippy in the corner that lets the user resize the dialog, but this still isn't great. Any idea what's going on here, bytesized?
|
Assignee | |
Comment 4•4 years ago
|
||
I see min-height: calc(375px); set on the .dialogBox element in release builds, and min-height: calc(300px); set on it in nightly.
|
|
Assignee | |
Comment 5•4 years ago
|
||
This happens in resizeVertically at https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/browser/components/preferences/in-content/subdialogs.js#383.
|
|
Assignee | |
Comment 6•4 years ago
|
||
For this dialog frame (this doc: https://searchfox.org/mozilla-central/source/browser/extensions/formautofill/content/manageAddresses.xhtml):
docEl.scrollHeight is read here: https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/browser/components/preferences/in-content/subdialogs.js#403. And it's value is now 222px instead of 297px as a result of this CSS rule that was added in Bug 1588142: https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/browser/themes/shared/incontentprefs/preferences.inc.css#25.
For resizing horizontally we have this condition that reads scrollWidth from doc.body if it exists: https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/browser/components/preferences/in-content/subdialogs.js#325-330. I'm guessing we should be doing the same for height.
Please notice that this issue reproduces also in the "Saved credit cards..." popup
|
|
Assignee | |
Comment 8•4 years ago
|
||
We were already doing this for scrollWidth, but after we started setting height: 100% on
root nodes in Bug 1588142, the scrollHeight computation was too small for <html> elements.
|
||
Updated•4 years ago
|
|
|
||
Comment 9•4 years ago
|
||
Looks like bgrins is on the case!
|
||
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53ca0eff415e For preference subdialog sizing, read scrollHeight from the body if it exists instead of the documentElement r=Gijs
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 12•4 years ago
|
||
Reproduced the issue with Firefox 72.0a1 (20191118213128) on Windows 10x64.
The issue is verified fixed using Firefox 72.0 (20191230161130) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. Checked while having extensions.formautofill.available set to "on".
|
|
||
Updated•2 years ago
|
Description
•