Closed Bug 1597210 Opened 2 months ago Closed 2 months ago

Saved addresses settings dialog buttons are hidden

Categories

(Firefox :: Preferences, defect, P1)

72 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 72
Tracking Status
firefox-esr68 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 --- verified

People

(Reporter: dekeltal, Assigned: bgrins)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Open settings > Privacy & Security > Forms and Autofill > Saved Addresses

Actual results:

Popup is too small, the buttons at the bottom are hidden. There's no scroll bar in this window. The only way to reach the buttons is to resize the window dragging from the bottom right corner.

Expected results:

Popup should be the right size to show all its contents. In extreme cases where it's not possible, at least it should have a scroll bar.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Preferences
The first bad revision is:
changeset:   591369:1f37c31422e2
user:        Kirk Steuber <ksteuber@mozilla.com>
date:        Thu Nov 14 00:17:01 2019 +0000
summary:     Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
Flags: needinfo?(ksteuber)
Keywords: regression
Regressed by: 1588142

This isn't disastrous because of the grippy in the corner that lets the user resize the dialog, but this still isn't great. Any idea what's going on here, bytesized?

I see min-height: calc(375px); set on the .dialogBox element in release builds, and min-height: calc(300px); set on it in nightly.

Please notice that this issue reproduces also in the "Saved credit cards..." popup

We were already doing this for scrollWidth, but after we started setting height: 100% on
root nodes in Bug 1588142, the scrollHeight computation was too small for <html> elements.

Attachment #9109740 - Attachment description: Bug 1597210 - Read scrollHeight from the body if it exists instead of the documentElement → Bug 1597210 - For preference subdialog sizing, read scrollHeight from the body if it exists instead of the documentElement

Looks like bgrins is on the case!

Assignee: nobody → bgrinstead
Priority: -- → P1
Flags: needinfo?(ksteuber)
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53ca0eff415e
For preference subdialog sizing, read scrollHeight from the body if it exists instead of the documentElement r=Gijs
Status: UNCONFIRMED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Flags: qe-verify+

Reproduced the issue with Firefox 72.0a1 (20191118213128) on Windows 10x64.
The issue is verified fixed using Firefox 72.0 (20191230161130) on Windows 10x64, macOS 10.15 and Ubuntu 18.04. Checked while having extensions.formautofill.available set to "on".

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.