1597245 - Delete Node should not be available on "#document" nodes

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open a page with iframes, for instance https://bug1592996-root.glitch.me/
• open inspector
• in the markup view expand an <iframe> tag
• right click on the "#document" element
• click on the "Delete Node" menu item

Expected results: Something should happen or the menu item should be disabled?
Actual results: Nothing happens, console logs:

console.error: "Error while calling actor 'domwalker's method 'removeNode'" "node.rawNode.remove is not a function"
console.error: "removeNode@resource://devtools/server/actors/inspector/walker.js:1819:18\nhandler@resource://devtools/shared/protocol/Actor.js:154:37\nonPacket@resource://devtools/server/debugger-server-connection.js:378:58\nreceiveMessage@resource://devtools/shared/transport/child-transport.js:66:16\nMessageListener.receiveMessage*_addListener@resource://devtools/shared/transport/child-transport.js:40:14\nready@resource://devtools/shared/transport/child-transport.js:57:10\n_onConnection@resource://devtools/server/debugger-server.js:450:15\nconnectToParent@resource://devtools/server/debugger-server.js:331:17\nonConnect<@resource://devtools/server/startup/frame.js:62:35\nexports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22\nMessageListener.receiveMessage*@resource://devtools/server/startup/frame.js:92:23\n@resource://devtools/server/startup/frame.js:174:5\n"

Note, this will also impact #shadow-root nodes after Bug 1596800 is solved

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1597245 - Disable 'Delete Node' option for document nodes. r=jdescottes

Added nodes of type DOCUMENT_NODE to the excluded types for deletion.

In order to test the context menu options for document nodes a new helper function getFrameDocument() got introduced that returns the document node of an iFrame.

It looks like #shadow-root nodes are already handled correctly, i.e. the "Delete Node" menu item is disabled for them. So I just fixed it for #document nodes.

Sebastian

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3738afec010
Disable 'Delete Node' option for document nodes. r=jdescottes

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b3738afec010