1597259 - Implement Page.setLifecycleEventsEnabled

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To be able to send Page.lifecycleEvents (bug 1597253) those have to be turned on first. This method accepts a boolean to turn it on or off.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Don’t we already implement Page.setLifecycleEventsEnabled as a no-op,
meaning it’s really Page.lifecycleEvent we’re missing?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Not sure what you mean, but the no-op doesn't turn on the events. This still has to be implemented for this method.

Comment 3

[Andreas Tolfsen ❲:ato❳]

I was pointing to the fact that in other cases where we have
similar enable/disable toggles, we have closed the meta bugs because
there’s no additional work left on them specifically: the implementation
work that needs to happen is with the events.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1597259 - [remote] Implement Page.setLifecycleEventsEnabled. r=#remote!

Depends on D53825

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We closed those because internally we set a flag for the current state. That's not what we did here, and as such the implementation is not complete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e9d52a8c4b7
[remote] Implement Page.setLifecycleEventsEnabled. r=remote-protocol-reviewers,maja_zf

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1e9d52a8c4b7