Implement Page.setLifecycleEventsEnabled
Categories
(Remote Protocol :: CDP, task, P1)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
()
Details
(Whiteboard: [puppeteer-alpha])
Attachments
(1 file)
To be able to send Page.lifecycleEvents (bug 1597253) those have to be turned on first. This method accepts a boolean to turn it on or off.
|
||
Comment 1•5 years ago
|
||
Don’t we already implement Page.setLifecycleEventsEnabled as a no-op,
meaning it’s really Page.lifecycleEvent we’re missing?
|
Assignee | |
Comment 2•5 years ago
|
||
Not sure what you mean, but the no-op doesn't turn on the events. This still has to be implemented for this method.
|
|
||
Comment 3•5 years ago
|
||
I was pointing to the fact that in other cases where we have
similar enable/disable toggles, we have closed the meta bugs because
there’s no additional work left on them specifically: the implementation
work that needs to happen is with the events.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D53825
|
|
Assignee | |
Comment 5•5 years ago
|
||
We closed those because internally we set a flag for the current state. That's not what we did here, and as such the implementation is not complete.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1e9d52a8c4b7 [remote] Implement Page.setLifecycleEventsEnabled. r=remote-protocol-reviewers,maja_zf
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
Description
•