1597268 - Remove registerContentHandler() and dom.registerContentHandler.enabled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Anne (:annevk)]

This has been removed for a while (see bug 1398169). We should cleanup our code and reduce the amount of preferences that might trigger unmaintained code paths.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1597268 - Remove Navigator#registerContentHandler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e348ec7e3a2b
Remove Navigator#registerContentHandler r=annevk,smaug

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset e348ec7e3a2b (bug 1597268) for causing mass bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=1cddc2938e75fa6ed39192891c386e9ff7d58904&tochange=ef38a4f612f62e4dcf4aeba2634ccefbb1f3320f&selectedJob=295816997

Backout link: https://hg.mozilla.org/integration/autoland/rev/ef38a4f612f62e4dcf4aeba2634ccefbb1f3320f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295816997&repo=autoland&lineNumber=1511

task 2020-04-01T19:21:30.033Z] 19:21:30     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1635, in _process_test_manifest
[task 2020-04-01T19:21:30.033Z] 19:21:30     INFO -      context)
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  ==============================
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  ==============================
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -      /builds/worker/checkouts/gecko/browser/components/protocolhandler/moz.build
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2020-04-01T19:21:30.034Z] 19:21:30    ERROR -      Error processing test manifest file /builds/worker/checkouts/gecko/browser/components/protocolhandler/test/mochitest.ini: Traceback (most recent call last):
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -        File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1567, in _process_test_manifest
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -          path, ', '.join(missing)), context)
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -      SandboxValidationError:
[task 2020-04-01T19:21:30.034Z] 19:21:30     INFO -      ==============================
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -      FATAL ERROR PROCESSING MOZBUILD FILE
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -      ==============================
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -      The error occurred while processing the following file or one of the files it includes:
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -          /builds/worker/checkouts/gecko/browser/components/protocolhandler/moz.build
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -      The error occurred when validating the result of the execution. The reported error is:
[task 2020-04-01T19:21:30.035Z] 19:21:30     INFO -          Test manifest (/builds/worker/checkouts/gecko/browser/components/protocolhandler/test/mochitest.ini) lists test that does not exist: test_registerHandler_disabled.html
[task 2020-04-01T19:21:30.371Z] 19:21:30     INFO -  *** Fix above errors and then restart with\
[task 2020-04-01T19:21:30.372Z] 19:21:30     INFO -                 "./mach build"
[task 2020-04-01T19:21:30.372Z] 19:21:30     INFO -  client.mk:111: recipe for target 'configure' failed
[task 2020-04-01T19:21:30.372Z] 19:21:30     INFO -  make: *** [configure] Error 1
[task 2020-04-01T19:21:30.497Z] 19:21:30    ERROR - Return code: 2
[task 2020-04-01T19:21:30.498Z] 19:21:30  WARNING - setting return code to 2
[task 2020-04-01T19:21:30.498Z] 19:21:30    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-04-01T19:21:30.498Z] 19:21:30    FATAL - Running post_fatal callback...
[task 2020-04-01T19:21:30.498Z] 19:21:30    FATAL - Exiting -1
[task 2020-04-01T19:21:30.498Z] 19:21:30     INFO - [mozharness: 2020-04-01 19:21:30.498111Z] Finished build step (failed)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3615a968dabf
Remove Navigator#registerContentHandler r=annevk,smaug

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3615a968dabf

Comment 6

[Chris Mills [:cmills]]

Oops, this is for removal of the handling code and pref, not the feature itself.