1597285 - Test "display-capture" permissions policy correctly.

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

From https://phabricator.services.mozilla.com/D53091#inline-322850:

[Feature policy "display-capture" can be enabled in cross-origin iframes using "allow" attribute.]
disabled: https://bugzilla.mozilla.org/show_bug.cgi?id=1596585

Is there any plan to fix that bug? I saw the comment there, that is a known limitation. If it is hard to fix that bug, maybe we should add a mochitest. I don't think it is too hard, a follow up should be ok

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 remove unused expectation data r?jib

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 use permissions-policy.js instead of feature-policy.js for display-capture r?jib

See also https://github.com/web-platform-tests/wpt/pull/28689

Depends on D119598

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 separate permissions-policy.js messages from testdriver messages r?jib

testdriver also uses postMessage().
https://github.com/web-platform-tests/wpt/blob/b32b3e223f63dc5500de31dfc117a03ec582f38d/tools/wptrunner/wptrunner/testdriver-extra.js#L144

Depends on D119599

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 remove no-op removeEventListener() r?jib

step_func() wraps handler() in another function, so the event listener is not
handler. The contentWindow check already made this unnecessary when added in https://github.com/web-platform-tests/wpt/commit/b39276663f92965ea1b2c7c10304f533a65b7e4e#diff-5736fcc16e67516fcf3749b67d299c03484b2e08941804d043aad2aff339e6a5R38

The recent evt.data.type avoids further potential unexpected consequences from
leaving the event handler in place.

Depends on D119600

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 disable testharness script loading in iframe documents r?jib

testdriver needs this for use in iframe documents.
https://github.com/web-platform-tests/wpt/blob/b32b3e223f63dc5500de31dfc117a03ec582f38d/tools/wptrunner/wptrunner/testdriver-extra.js#L164

Depends on D119601

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 use test_driver.set_test_context() in iframe documents r?jib

https://web-platform-tests.org/writing-tests/testdriver.html#using-testdriver-in-other-browsing-contexts

Depends on D119602

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 replace custom user gesture with test_driver.bless() r?jib

Depends on D119603

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 test each of audio, video, audio+video combinations r?jib

instead of testing that any one of these is disallowed in cross-origin iframes.

Splitting the test into separate files is also helpful due to run times
getting close to timeouts in some configurations.

Depends on D119604

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: Bug 1597285 test allow attribute can disable default-self permissions policies in same-origin frames r?jib

Depends on D119605

Comment 11

[Karl Tomlinson (:karlt)]

https://github.com/web-platform-tests/wpt/pull/26411 will provide stable results with these changes.

https://treeherder.mozilla.org/jobs?repo=try&author=ktomlinson%40mozilla.com

Comment 12

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Renaming issue to reflect wpt patches and bug 1596585 having since been fixed.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03a42c4949e0
remove unused expectation data r=jib
https://hg.mozilla.org/integration/autoland/rev/a714aa598706
use permissions-policy.js instead of feature-policy.js for display-capture r=jib
https://hg.mozilla.org/integration/autoland/rev/0606d607518f
separate permissions-policy.js messages from testdriver messages r=jib
https://hg.mozilla.org/integration/autoland/rev/fc16816a4027
remove no-op removeEventListener() r=jib
https://hg.mozilla.org/integration/autoland/rev/f161599c2482
disable testharness script loading in iframe documents r=jib
https://hg.mozilla.org/integration/autoland/rev/5b131f57a8d5
use test_driver.set_test_context() in iframe documents r=jib
https://hg.mozilla.org/integration/autoland/rev/8e73cbfca53f
replace custom user gesture with test_driver.bless() r=jib
https://hg.mozilla.org/integration/autoland/rev/26e100d6b750
test each of audio, video, audio+video combinations r=jib
https://hg.mozilla.org/integration/autoland/rev/8605099395b2
test allow attribute can disable default-self permissions policies in same-origin frames r=jib

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29779 for changes under testing/web-platform/tests

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/03a42c4949e0
https://hg.mozilla.org/mozilla-central/rev/a714aa598706
https://hg.mozilla.org/mozilla-central/rev/0606d607518f
https://hg.mozilla.org/mozilla-central/rev/fc16816a4027
https://hg.mozilla.org/mozilla-central/rev/f161599c2482
https://hg.mozilla.org/mozilla-central/rev/5b131f57a8d5
https://hg.mozilla.org/mozilla-central/rev/8e73cbfca53f
https://hg.mozilla.org/mozilla-central/rev/26e100d6b750
https://hg.mozilla.org/mozilla-central/rev/8605099395b2

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot