Closed
Bug 1597424
Opened 4 years ago
Closed 4 years ago
Fix uses of AllDescendantsOfType in dom/base/nsFrameLoader.cpp
Categories
(Core :: DOM: Navigation, defect, P3)
Core
DOM: Navigation
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(2 files, 1 obsolete file)
In file dom/base/nsFrameLoader.cpp
Checks if all descendents have the right type.
Change to using BrowsingContext.
Used by SwapWithOtherLoader.
Comment 1•4 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: --- → M6
Updated•4 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•4 years ago
|
||
Assignee | ||
Comment 4•4 years ago
|
||
Updated•4 years ago
|
Attachment #9121763 -
Attachment is obsolete: true
Comment 5•4 years ago
|
||
Hi Tetsuharu, are your nsFrameLoader patches here ready to land? kmag has now r+'d both of your patches.
Flags: needinfo?(tetsuharu.ohzeki)
Assignee | ||
Comment 6•4 years ago
|
||
Sorry. I missed this bug. I'll land them.
Flags: needinfo?(tetsuharu.ohzeki)
Pushed by tetsuharu.ohzeki@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bc6d0df3c604 part 1: Fix uses of nsIDocShellTreeItem in AllDescendantsOfType in dom/base/nsFrameLoader.cpp. r=kmag https://hg.mozilla.org/integration/autoland/rev/ea8afa08d362 part 2: Remove usages of nsDocShell::ItemType() in nsFrameLoader::SwapWithOtherLoader(). r=kmag
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc6d0df3c604
https://hg.mozilla.org/mozilla-central/rev/ea8afa08d362
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•