Closed Bug 1597424 Opened 1 year ago Closed 8 months ago

Fix uses of AllDescendantsOfType in dom/base/nsFrameLoader.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Fission Milestone M6
Tracking Status
firefox77 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(2 files, 1 obsolete file)

In file dom/base/nsFrameLoader.cpp

Checks if all descendents have the right type.

Change to using BrowsingContext.

Used by SwapWithOtherLoader.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Blocks: 1597425
Attachment #9121763 - Attachment is obsolete: true

Hi Tetsuharu, are your nsFrameLoader patches here ready to land? kmag has now r+'d both of your patches.

Flags: needinfo?(tetsuharu.ohzeki)

Sorry. I missed this bug. I'll land them.

Flags: needinfo?(tetsuharu.ohzeki)
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bc6d0df3c604
part 1: Fix uses of nsIDocShellTreeItem in AllDescendantsOfType in dom/base/nsFrameLoader.cpp. r=kmag
https://hg.mozilla.org/integration/autoland/rev/ea8afa08d362
part 2: Remove usages of nsDocShell::ItemType() in nsFrameLoader::SwapWithOtherLoader(). r=kmag
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.