Closed Bug 1597432 Opened 2 years ago Closed 1 year ago

Audit nsIDocShellTreeItem usage in IsCaretOnInWindow in dom/base/nsGlobalWindowCommands.cpp


(Core :: DOM: Navigation, defect, P3)




Fission Milestone M6b


(Reporter: djvj, Unassigned)


(Blocks 1 open bug)


(Whiteboard: [rm-docshell-tree-item:simple])

In file dom/base/nsGlobalWindowCommands.cpp

Checks DocShell ItemType against nsIDocShellTreeItem type

Change to use BrowsingContext item type.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

We need to audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the current process and the corresponding nsIDocShellTreeItem methods will return null.

If this code is broken with Fission, fixing it blocks enabling Fission is Nightly.

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Fission documentation about replacing nsIDocShellTree Item:

:farre's presentation with examples of replacing nsIDocShellTreeItem with BrowsingContext, WindowContext, SyncedContexts, and BrowsingContextGroup:

Summary: Fix uses of IsCaretOnInWindow in dom/base/nsGlobalWindowCommands.cpp → Audit nsIDocShellTreeItem usage in IsCaretOnInWindow in dom/base/nsGlobalWindowCommands.cpp

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6b
  if (docShell && docShell->ItemType() == nsIDocShellTreeItem::typeChrome) 

This is querying for item type which is fine.

Closed: 1 year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.