1597442 - Fix uses of nsJSContext::MaybeRunNextCollectorSlice in dom/base/nsJSEnvironment.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file dom/base/nsJSEnvironment.cpp

Uses DocShell tree to check if argument DocShell is the same-type root for its tree. Internals not used.

Change to using BrowsingContext.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597442 - Remove the usage of nsIDocShellTreeItem from nsJSContext::MaybeRunNextCollectorSlice().

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tetsuharu, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Olli, May I land this?
I heard that your work might make this patch unnecessary.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, what work?
As far as I see, this could land.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Aha, thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f066f0e696e3
Remove the usage of nsIDocShellTreeItem from nsJSContext::MaybeRunNextCollectorSlice(). r=smaug

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f066f0e696e3