1597447 - Audit nsIDocShellTreeItem usage in nsHTMLDocument::StartDocumentLoad in dom/html/nsHTMLDocument.cpp

Status: RESOLVED DUPLICATE of bug 1597398

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file dom/html/nsHTMLDocument.cpp

Uses DocShell tree to get parent item.

Some of the code around this seems to have been fixed for Fission, e.g. the following fix within the call to Document::StartDocumentLoad https://bugzilla.mozilla.org/show_bug.cgi?id=1555050

Obtains the ContentViewer from either the current DocShell or the parent DocShell.

Users of Content-Viewer are conditionalized, and lack of one won’t crash. Might lead to failures in specific tests when the docshell content-viewer is null, and its parent is out of process.

Uses content-viewer exactly twice, here:

• https://searchfox.org/mozilla-central/rev/b2b0077c2e6a516a76bf8077d6f0237c58f5959a/dom/html/nsHTMLDocument.cpp#600
• In the call to TryUserForcedCharset, the content-viewer is only used for mailnews: https://searchfox.org/mozilla-central/rev/2a10f4812f3f7c7645d253a4fe52f26bf58e20e8/dom/html/nsHTMLDocument.cpp#239
• Other use is TryHintCharset here: https://searchfox.org/mozilla-central/rev/2a10f4812f3f7c7645d253a4fe52f26bf58e20e8/dom/html/nsHTMLDocument.cpp#206
  • Gets and set charset hint-related data from the ContentViewer.
• Forward Charset Hint data during document creation process, and remove this code.
• IPC not advised.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Chris Peterson [:cpeterson]]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

:hsivonen, this seems to be charset hint related, which you're more familiar with than me. Any thoughts as to what might need to be done here when you get back?

Comment 5

[Chris Peterson [:cpeterson]]

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.