Closed Bug 1597458 Opened 6 years ago Closed 5 years ago

Fix uses of nsContentBlocker::ShouldProcess in extensions/permissions/nsContentBlocker.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED INVALID
Project Flags:
Fission Milestone M6

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

In file extensions/permissions/nsContentBlocker.cpp

https://searchfox.org/mozilla-central/rev/2a10f4812f3f7c7645d253a4fe52f26bf58e20e8/extensions/permissions/nsContentBlocker.cpp#231

Gets ItemType of DocShellTreeItem, by QueryInterfacing argument nsILoadInfo->GetLoadingContext() to nsIDocShellTreeItem.

Only uses ItemType, no further inspection of internals.

Change to Query-Interface it to an nsIDocShell, and get the mBrowsingContext off of that to check ItemType.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

ContentBlocker will probably be removed in bug 1357107, so this has a low priority.

ContentBlocker was removed in bug 1357107. Closing this bug.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.