Open Bug 1597461 Opened 2 months ago Updated 2 months ago

Fix uses of GetRemoteObjectTag in js/ipc/WrapperOwner.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

Fission Milestone M6

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:hard])

In file js/ipc/WrapperOwner.cpp

Checks if an incoming nsISupports is an nsIDocShellTreeItem (using QueryInterface), and if so returns a static string.

The only uses of this is to generate a tag string that is passed around places with CPOWs, and never really used by anyone except for equality checks relating to CPOWs.

This should likely change to simply checking for the nsIDocShell interface, and if so returning the literal string “ContentDocShell”

As nothing else reads that string (except the comparison operator), it’s unlikely that any tests will break if you change it.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.