Closed Bug 1597461 Opened 4 years ago Closed 4 years ago

Remove `getCrossProcessWrapperTag` CPOW logic

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1620226

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:hard])

In file js/ipc/WrapperOwner.cpp

Checks if an incoming nsISupports is an nsIDocShellTreeItem (using QueryInterface), and if so returns a static string.

The only uses of this is to generate a tag string that is passed around places with CPOWs, and never really used by anyone except for equality checks relating to CPOWs.

This should likely change to simply checking for the nsIDocShell interface, and if so returning the literal string “ContentDocShell”

As nothing else reads that string (except the comparison operator), it’s unlikely that any tests will break if you change it.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

There are no uses of getCrossProcessWrapperTag left in the tree, as far as I can tell, so we can probably remove the code related to it entirely. https://searchfox.org/mozilla-central/search?q=getCrossProcessWrapperTag&path=

Summary: Fix uses of GetRemoteObjectTag in js/ipc/WrapperOwner.cpp → Remove `getCrossProcessWrapperTag` CPOW logic

Deferring to Fission M7 Beta because removing unused code doesn't need to block enabling Fission in Nightly.

Fission Milestone: M6 → M7

This code was removed in bug 1620226.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.

Fission Milestone: M7 → ---
You need to log in before you can comment on or make changes to this bug.