1597478 - Fix uses of nsDocumentViewer::ShouldAttachToTopLevel in layout/base/nsDocumentViewer.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file layout/base/nsDocumentViewer.cpp

Compares ItemType against typeChrome.

Change to using BrowsingContext.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597478 - Fix uses of nsIDocShellTreeItem in nsDocumentViewer::ShouldAttachToTopLevel().

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb3b2f1b96e2
Fix uses of nsIDocShellTreeItem in nsDocumentViewer::ShouldAttachToTopLevel(). r=emilio

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597478 - follow up: add the null check for `mPresContext`.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a5ddda7a226
follow up: add the null check for `mPresContext`. r=emilio

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cb3b2f1b96e2
https://hg.mozilla.org/mozilla-central/rev/2a5ddda7a226