Closed Bug 1597480 Opened 1 year ago Closed 10 months ago

Fix uses of nsPresContext::Init in layout/base/nsPresContext.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla74
Fission Milestone M6
Tracking Status
firefox74 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file, 1 obsolete file)

In file layout/base/nsPresContext.cpp

Obtains a refresh driver from the same-process parent.

The concept of a refresh driver from another process does not make logical sense.

This seems like a situation where out-of-process parent should lead to “create new refresh driver in-process”.

Change to use BrowsingContext.

Break out of loop (and fall through to “create new refresh driver” code) if parent is out-of-process.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/63a67b948290
Fix uses of nsIDocShellTreeItem in nsPresContext::Init. r=emilio,bzbarsky

Seeing some other failures which appeared on these changes:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-e10s&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284329988

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-e10s-5%2Cm%285%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336742

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-e10s-6%2Cm%286%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336819

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=linux%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux64-shippable%2Fopt-mochitest-e10s-4%2Cm%284%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284344810

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=mochitest-media-e10s-2%2Cm%28mda2%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336850

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-e10s-3%2Cm%283%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336618

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=windows%2C7%2Cshippable%2Copt%2Cmochitests%2Ctest-windows7-32-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284346103

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284346103&repo=autoland&lineNumber=5223

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336618&repo=autoland&lineNumber=47407

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336850&repo=autoland&lineNumber=14568

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284344810&repo=autoland&lineNumber=10650

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336819&repo=autoland&lineNumber=3991

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336742&repo=autoland&lineNumber=5363

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284329988&repo=autoland&lineNumber=34616

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284339136&repo=autoland&lineNumber=22363

Attachment #9120205 - Attachment is obsolete: true

I tried this patch on try again, but I trouble with judgment about whether this patch causes failures listed in comment 5.

So I reland this patch again and if there are some problems, I'll debug it again...

Flags: needinfo?(tetsuharu.ohzeki)
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a64dec7a0be6
Fix uses of nsIDocShellTreeItem in nsPresContext::Init. r=emilio,bzbarsky
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.