1597480 - Fix uses of nsPresContext::Init in layout/base/nsPresContext.cpp

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file layout/base/nsPresContext.cpp

Obtains a refresh driver from the same-process parent.

The concept of a refresh driver from another process does not make logical sense.

This seems like a situation where out-of-process parent should lead to “create new refresh driver in-process”.

Change to use BrowsingContext.

Break out of loop (and fall through to “create new refresh driver” code) if parent is out-of-process.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: Bug 1597480 - Fix uses of nsIDocShellTreeItem in nsPresContext::Init.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63a67b948290
Fix uses of nsIDocShellTreeItem in nsPresContext::Init. r=emilio,bzbarsky

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 63a67b948290 (Bug 1597480) for mochitest failures at test_relative_update.html.
https://hg.mozilla.org/integration/autoland/rev/feb7d997f96164b028c9cf57a74878095cdad0d3

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=284322552&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=63a67b948290517ce36e1e23ab912fecd8547a6e

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284322552&repo=autoland&lineNumber=20398

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Seeing some other failures which appeared on these changes:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cquantumrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-e10s&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284329988

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-e10s-5%2Cm%285%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336742

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-e10s-6%2Cm%286%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336819

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=linux%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-linux64-shippable%2Fopt-mochitest-e10s-4%2Cm%284%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284344810

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=mochitest-media-e10s-2%2Cm%28mda2%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336850

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-e10s-3%2Cm%283%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284336618

https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=feb7d997f96164b028c9cf57a74878095cdad0d3&searchStr=windows%2C7%2Cshippable%2Copt%2Cmochitests%2Ctest-windows7-32-shippable%2Fopt-mochitest-devtools-chrome-e10s-1%2Cm%28dt1%29&fromchange=d0d7ed8937ea2ac7ea4fc89cef7fa6ccd0dbce5d&selectedJob=284346103

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284346103&repo=autoland&lineNumber=5223

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336618&repo=autoland&lineNumber=47407

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336850&repo=autoland&lineNumber=14568

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284344810&repo=autoland&lineNumber=10650

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336819&repo=autoland&lineNumber=3991

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284336742&repo=autoland&lineNumber=5363

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284329988&repo=autoland&lineNumber=34616

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284339136&repo=autoland&lineNumber=22363

Comment 6

[Ricky Stewart]

Attachment: Backed out changeset 63a67b948290 (Bug 1597480) for mochitest failures at test_relative_update.html. CLOSED TREE

Comment 7

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

I tried this patch on try again, but I trouble with judgment about whether this patch causes failures listed in comment 5.

So I reland this patch again and if there are some problems, I'll debug it again...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a64dec7a0be6
Fix uses of nsIDocShellTreeItem in nsPresContext::Init. r=emilio,bzbarsky

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a64dec7a0be6