1597497 - Remove nsIDocShellTreeItem interface in toolkit/components/browser/nsWebBrowser.cpp

Status: NEW

(Core :: DOM: Navigation, defect, P3)

Description

[Kannan Vijayan [:djvj]]

In file toolkit/components/browser/nsWebBrowser.cpp

All the uses of nsIDocShellTreeItem in here are strictly the implementation methods for the API (the ones used everywhere else).

Make a watcher bug - once all uses of nsIDocShellTreeItem are dead, these methods will be removed with whatever patch removes the datatype itself.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Chris Peterson [:cpeterson]]

Kannan, does this bug block shipping Fission MVP? Or is this work only needed when we eventually kill nsIDocShellTreeItem entirely in rmrf-docshell-tree-item bug 1607591 (after shipping Fission MVP)?

Comment 3

[Kannan Vijayan [:djvj]]

The latter - this doesn't need to block Fission MVP if we don't want it to, and can be scheduled for follow-up clean-ups after the nsIDocShellTreeItem type is removed entirely.

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Kannan Vijayan [:djvj] from comment #3)

The latter - this doesn't need to block Fission MVP if we don't want it to, and can be scheduled for follow-up clean-ups after the nsIDocShellTreeItem type is removed entirely.

Thanks. In that case, I'll postpone this bug until after Fission MVP.