Open Bug 1597497 Opened 2 years ago Updated 2 years ago

Remove nsIDocShellTreeItem interface in toolkit/components/browser/nsWebBrowser.cpp

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

Fission Milestone Future

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:validate])

In file toolkit/components/browser/nsWebBrowser.cpp

All the uses of nsIDocShellTreeItem in here are strictly the implementation methods for the API (the ones used everywhere else).

Make a watcher bug - once all uses of nsIDocShellTreeItem are dead, these methods will be removed with whatever patch removes the datatype itself.

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: --- → M6
Priority: -- → P3

Kannan, does this bug block shipping Fission MVP? Or is this work only needed when we eventually kill nsIDocShellTreeItem entirely in rmrf-docshell-tree-item bug 1607591 (after shipping Fission MVP)?

Flags: needinfo?(kvijayan)
Summary: Fix uses of Single bug for entire file. in toolkit/components/browser/nsWebBrowser.cpp → Remove nsIDocShellTreeItem interface in toolkit/components/browser/nsWebBrowser.cpp

The latter - this doesn't need to block Fission MVP if we don't want it to, and can be scheduled for follow-up clean-ups after the nsIDocShellTreeItem type is removed entirely.

Flags: needinfo?(kvijayan)

(In reply to Kannan Vijayan [:djvj] from comment #3)

The latter - this doesn't need to block Fission MVP if we don't want it to, and can be scheduled for follow-up clean-ups after the nsIDocShellTreeItem type is removed entirely.

Thanks. In that case, I'll postpone this bug until after Fission MVP.

Fission Milestone: M6 → ---
Fission Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.