1597516 - Fix uses of nsContentTreeOwner::GetInterface in xpfe/appshell/nsContentTreeOwner.cpp

Status: NEW

(Core :: DOM: Navigation, enhancement, P3)

Description

[Kannan Vijayan [:djvj]]

In file xpfe/appshell/nsContentTreeOwner.cpp

Returns mAppWindow->mDocShell as an nsIDocShellTreeItem.

https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/xpfe/appshell/nsContentTreeOwner.cpp#132

Should be removable after docshell tree is removed (actually, probably needs to be removed at same time as docshell tree).

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Nika Layzell [:nika] (ni? for response)]

This is a simple cleanup which can be done whenever the interface itself is removed, and shouldn't be counted as a major work item

Comment 3

[Kannan Vijayan [:djvj]]

Moving to new tracking bug as discussed.

Comment 4

[Chris Peterson [:cpeterson]]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Nika Layzell [:nika] (ni? for response) from comment #2)

This is a simple cleanup which can be done whenever the interface itself is removed, and shouldn't be counted as a major work item

In that case, I will move this bug to the Fission Future milestone (for post-MVP work).