Closed
Bug 1597554
Opened 5 years ago
Closed 5 years ago
Port |Bug 537378 - "search messages" (Ctrl+Shift+F) should be enabled in the 3pane - doesn't open if no folder or account selected/focused in folder pane.| to SeaMonkey
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.69
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file, 1 obsolete file)
|
6.07 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
At the moment Ctrl+Shift+S doesn't open search messages if nothing is selected in the folder pane. Let's port:
- Bug 537378 - "search messages" (Ctrl+Shift+F) should be enabled in the 3pane - doesn't open if no folder or account selected/focused in folder pane.
Also port parts of: - Bug 501516 -- right click folder -> search causes the search to be in the displayed folder, not the selected one
This will fix an issue when nothing is selected and align the MsgSearchMessages function more with TB version.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: No search message dialog shown in certain circumstances
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Attachment #9109845 -
Flags: review?(frgrahl)
Attachment #9109845 -
Flags: approval-comm-release?
Attachment #9109845 -
Flags: approval-comm-esr60?
Missed one bit of port, thanks to frg for spotting
Attachment #9109845 -
Attachment is obsolete: true
Attachment #9109845 -
Flags: review?(frgrahl)
Attachment #9109845 -
Flags: approval-comm-release?
Attachment #9109845 -
Flags: approval-comm-esr60?
Attachment #9110863 -
Flags: review?(frgrahl)
Attachment #9110863 -
Flags: approval-comm-release?
Attachment #9110863 -
Flags: approval-comm-esr60?
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9110863 [details] [diff] [review] Update search messages v1.1 LGTM
Attachment #9110863 -
Flags: review?(frgrahl)
Attachment #9110863 -
Flags: review+
Attachment #9110863 -
Flags: approval-comm-release?
Attachment #9110863 -
Flags: approval-comm-release+
Attachment #9110863 -
Flags: approval-comm-esr60?
Attachment #9110863 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/64a1253ed5a8
Port |Bug 537378 - "search messages" (Ctrl+Shift+F) should be enabled in the 3pane - doesn't open if no folder or account selected/focused in folder pane.|. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/07bd596b3318 Fix incorrect import of mailServices.jsm. r=me
|
|
||
Comment 6•5 years ago
|
||
status-seamonkey2.49esr:
--- → wontfix
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
Target Milestone: --- → seamonkey2.69
|
|
||
Comment 7•4 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•