1597558 - Raygun.io middleware can't report errors on Python 3 branch

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect)

Description

[Jarek Śmiejczak [:jotes]]

Integration with Raygun.io doesn't work on Python 3 because the middleware throws an exception:

AttributeError at /
'bytes' object has no attribute '__traceback__'

The exception is caused by RaygunExceptionMiddleware because it sends bytes instead of an exception object to the parent class.

Also, I noticed that Raygun4py has separate implementations of the library Python 2 and Python 3 and they slightly differ:

diff -u  python3/raygun4py/raygunprovider.py python2/raygun4py/raygunprovider.py
--- python3/raygun4py/raygunprovider.py	2019-11-19 00:49:20.289637395 +0100
+++ python2/raygun4py/raygunprovider.py	2019-11-19 00:49:20.289637395 +0100
@@ -4,9 +4,12 @@
(...)
     def set_user(self, user):
@@ -89,10 +93,16 @@
         exc_type, exc_value, exc_traceback = exc_info
 
         if exception is not None:
-            errorMessage = raygunmsgs.RaygunErrorMessage(type(exception), exception, exception.__traceback__, options)
+            errorMessage = raygunmsgs.RaygunErrorMessage(type(exception), exception, exc_traceback, options)
         else:
             errorMessage = raygunmsgs.RaygunErrorMessage(exc_type, exc_value, exc_traceback, options)
 
+        # Prevent circular reference for GC - https://docs.python.org/2/library/sys.html#sys.exc_info
+        try:
+            del exc_type, exc_value, exc_traceback
+        except Exception as e:
+            raise
+
         tags, custom_data, http_request, extra_environment_data = self._parse_args(kwargs)
         message = self._create_message(errorMessage, tags, custom_data, http_request, extra_environment_data)
         message = self._transform_message(message)

That's probably the reason why the problem wasn't noticed sooner.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1506

Comment 2

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/1c9089090f147c4a99df89c926bc08bdda68fb76