1597573 - Triqui language only shown as 'trs' in dropdown for accept languages

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1583177 added the Triqui language as an option to choose from the list of accept languages in Options > General > Language > Choose your preferred language for displaying pages.

It's only shown as 'trs' in both 71.0b11 and 72.0a1 20191118093852.

trs needs to be added at https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/toolkit/components/mozintl/mozIntl.jsm#171

Comment 1

[Francesco Lodolo [:flod]]

Unfortunately that's not something I was aware of. Leaving it here for now, to see if someone can pick it up before me.

While not ideal, I don't consider this a blocker, we shipped locales for years without an associated displayed language names.

Comment 2

[Francesco Lodolo [:flod]]

Note: this is not a regression, it's a task that needs to be completed. It was possible to add trs manually to accept-languages before (via about:config), like any other language, and it would show up as the locale code, because there's no language name associated to it.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Bug 1597573 - Add trs to availableLocaleDisplayNames in mozIntl.jsm

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3627a56e5003
Add trs to availableLocaleDisplayNames in mozIntl.jsm r=Pike

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3627a56e5003

Comment 7

[Francesco Lodolo [:flod]]

Verified on 72.0a1 (2019-11-19) (64 bit)

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 9109892 [details]
Bug 1597573 - Add trs to availableLocaleDisplayNames in mozIntl.jsm

Beta/Release Uplift Approval Request

• User impact if declined: trs  language is displayed as locale code in the language settings for Web Content
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only adding the locale code to an existing list to pick up the associated language name.
• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9109892 [details]
Bug 1597573 - Add trs to availableLocaleDisplayNames in mozIntl.jsm

No risk, uplift approved for 71 beta 12, thanks.

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/574cae0fc04d