Closed Bug 1597588 Opened 6 years ago Closed 6 years ago

Make rust's Atom non-zero.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1559076 introduces various APIs that return Option<Atom>.

There's no reason that needs to take more than a pointer as Atom isn't nullable.

At first I thought this was going to enable simplifications in the selector
parser (to simplify the attribute selector setup), but I couldn't end up
shrinking the layout enough.

However this should help with bug 1559076, which returns Option<Atom>, and it
was easy to write.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/12f90b54f2cb Make rust Atom use NonZeroUsize. r=heycam
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: