1597653 - test_bug453650.xhtml uses various unknown properties Ci.<interface>.equals

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mark Banner (:standard8)]

Following the recent move of the test file from xul to xhtml, ESLint is able to process more of it. I have a script that checks for undefined Ci.* properties in use, and it picked up this bit:

      QueryInterface: function (iid) {
        if (Ci.nsIReflowObserver.equals(iid) ||
            Ci.nsISupportsWeakReference.equals(iid) ||
            Ci.nsISupports.equals(iid))
          return this;
        throw Cr.NS_ERROR_NO_INTERFACE;
      },

The interfaces have either never supported .equals or only did so a long time ago, so these are all uses of an unknown property. In addition, this should just be changed to use ChromeUtils.generateQI.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1597653 - Fix uses of unknown property 'equals' in test_bug453650.xhtml. r?smaug

Change the QueryInterface function to use ChromeUtils.generateQI.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6290bf0c39f7
Fix uses of unknown property 'equals' in test_bug453650.xhtml. r=smaug

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6290bf0c39f7