1597698 - move all megabar related prefs (stripHttps, searchIcon, ...) prefs under a common branch

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Marco Bonardo [:mak]]

We would like to collect all the prefs related to the redesign under the same branch, to make it simpler to toggle on-off all the parts.

Comment 1

[Marco Bonardo [:mak]]

Verdi suggested:

what about: browser.urlbar.quantumbar.______ so designupdate, searchicon, striphttps, etc.?
and then tips, interventions, topsites
searchicon > searchbutton

Comment 2

[Marco Bonardo [:mak]]

I think Verdi would like this to be addressed before we re-enable the feature in Nightly.
Though, we didn't come up with a naming scheme yet.

Comment 3

[Verdi [:verdi] Best to slack me]

Let's use "update1" for the things we're working on now. At some point in the future we can start an "update2" branch.

Comment 4

[Harry Twyford]

Attachment: Bug 1597698 - Move all megabar prefs under a urlbar.update1 branch. r?mak

Comment 5

[Dão Gottwald [:dao]]

Is there a good reason to not just flip urlbar.view.stripHttps right now without the other changes? Seems like this would save some back-and-forth changes.

Comment 6

[Harry Twyford]

Per the planning meeting today, it sounds like mconnor wants to ship this with the rest of the megabar.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Harry Twyford [:harry] from comment #6)

Per the planning meeting today, it sounds like mconnor wants to ship this with the rest of the megabar.

That wasn't my takeaway. He was speaking generally, but then agreed that this particular change makes sense to ship when it's ready as we did in other few cases. He then pointed out the trailing slash bug for which I filed bug 1598345.

Comment 8

[Marco Bonardo [:mak]]

I understood it the same way as Harry, that we want to ship this change as part of the redesign.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f20b5691b6b9
Move all megabar prefs under a urlbar.update1 branch. r=mak,dao

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f20b5691b6b9