Closed Bug 1597704 Opened 1 year ago Closed 11 months ago

Remove usage of GetURI in nsContentSecurityManager.cpp

Categories

(Core :: DOM: Security, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: sstreich, Assigned: sstreich)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [domsecurity-active])

Attachments

(1 file)

See Metabug

Assignee: nobody → sstreich
Priority: -- → P2
Whiteboard: [domsecurity-active]
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4082b974a1e6
Move is OriginPotentially Trustworthy into Principal r=ckerschb

Sorry about that, fixed the Test should now work probably 🤞

Flags: needinfo?(sstreich)
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74162d71ef4d
Move is OriginPotentially Trustworthy into Principal r=ckerschb

Backed out changeset 74162d71ef4d (bug 1597704) for failing at browser_insecurePasswordConsoleWarning.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d89bbe494f6b6f1fc9839bdb204afaf64d42f75c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=74162d71ef4d440cc28f8e9c76b7142483d1daf9&selectedJob=278251512

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278251512&repo=autoland&lineNumber=24282

Log snippet:

[task 2019-11-26T17:11:08.577Z] 17:11:08 INFO -
[task 2019-11-26T17:11:08.580Z] 17:11:08 INFO - Console message: [JavaScript Error: "_fillForm: autofillResult must be specified" {file: "resource://gre/modules/LoginManagerChild.jsm" line: 2104}]
[task 2019-11-26T17:11:08.581Z] 17:11:08 INFO - _fillForm@resource://gre/modules/LoginManagerChild.jsm:2104:15
[task 2019-11-26T17:11:08.581Z] 17:11:08 INFO - loginsFound@resource://gre/modules/LoginManagerChild.jsm:980:10
[task 2019-11-26T17:11:08.581Z] 17:11:08 INFO - promise callback*_fetchLoginsFromParentAndFillForm@resource://gre/modules/LoginManagerChild.jsm:867:8
[task 2019-11-26T17:11:08.581Z] 17:11:08 INFO - _processDOMFormHasPasswordEvent@resource://gre/modules/LoginManagerChild.jsm:750:10
[task 2019-11-26T17:11:08.581Z] 17:11:08 INFO - onDOMFormHasPassword@resource://gre/modules/LoginManagerChild.jsm:737:12
[task 2019-11-26T17:11:08.582Z] 17:11:08 INFO - handleEvent@resource://gre/modules/LoginManagerChild.jsm:536:14
[task 2019-11-26T17:11:08.582Z] 17:11:08 INFO -
[task 2019-11-26T17:11:08.582Z] 17:11:08 INFO - Buffered messages finished
[task 2019-11-26T17:11:08.583Z] 17:11:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_insecurePasswordConsoleWarning.js | Test timed out -
[task 2019-11-26T17:11:08.583Z] 17:11:08 INFO - GECKO(8164) | MEMORY STAT | vsize 3165MB | residentFast 382MB | heapAllocated 124MB
[task 2019-11-26T17:11:08.583Z] 17:11:08 INFO - TEST-OK | toolkit/components/passwordmgr/test/browser/browser_insecurePasswordConsoleWarning.js | took 90062ms
[task 2019-11-26T17:11:08.583Z] 17:11:08 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-11-26T17:11:08.584Z] 17:11:08 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/browser/browser_insecurePasswordConsoleWarning.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/components/passwordmgr/test/browser/form_basic.html -
[task 2019-11-26T17:11:08.585Z] 17:11:08 INFO - GECKO(8164) | ++DOCSHELL 0x7f4fe04cc800 == 1 [pid = 11021] [id = {4bd8518c-a9a7-4ae3-81c7-6e0940cfea71}]
[task 2019-11-26T17:11:08.585Z] 17:11:08 INFO - GECKO(8164) | ++DOMWINDOW == 1 (0x7f4fe0320f20) [pid = 11021] [serial = 1] [outer = (nil)]
[task 2019-11-26T17:11:08.586Z] 17:11:08 INFO - GECKO(8164) | ++DOMWINDOW == 2 (0x7f4fe044e800) [pid = 11021] [serial = 2] [outer = 0x7f4fe0320f20]
[task 2019-11-26T17:11:08.590Z] 17:11:08 INFO - checking window state

Flags: needinfo?(sstreich)

test_ext_trustworthy_origin

Another failure which seems to have been introduced with these changes:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278254006&repo=autoland&lineNumber=4868
[task 2019-11-26T17:49:27.420Z] 17:49:27 INFO - TEST-START | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_trustworthy_origin.js
[task 2019-11-26T17:49:27.954Z] 17:49:27 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_trustworthy_origin.js | xpcshell return code: 0
[task 2019-11-26T17:49:27.954Z] 17:49:27 INFO - TEST-INFO took 577ms

Sorry about that. updated the revision :)

Flags: needinfo?(sstreich)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68ff34ec8e96
Move is OriginPotentially Trustworthy into Principal r=ckerschb
Blocks: 1600051

(In reply to Stefan Hindli [:stefan_hindli] from comment #10)

Backed out

Basti is on it.

Flags: needinfo?(ckerschb)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0597837b938c
Backed out changeset 68ff34ec8e96 for causing perma bc3 failures in browser/extensions/formautofill/test/browser/browser_autocomplete_footer.js CLOSED TREE
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/004e1d5e38cb
Move is OriginPotentially Trustworthy into Principal r=ckerschb
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
Blocks: 1601941
No longer blocks: 1601941
You need to log in before you can comment on or make changes to this bug.