1597706 - Prevent What's New toolbar badging in 71

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Andrei Oprea [:andreio]]

We need to remove the message and prevent the badge from showing up in 71 because we don't have any new content.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1597706 - Remove the What's new toolbar badge message

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6eb852a8739
Remove the What's new toolbar badge message r=k88hudson

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1597706 - Remove the What's new toolbar badge message

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9110319 [details]
Bug 1597706 - Remove the What's new toolbar badge message

Beta/Release Uplift Approval Request

• User impact if declined: We don't want to show the users the What's New Panel feature because we don't have any new content.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Code is tested, we removed a feature
• String changes made/needed:

Comment 5

[Andrei Oprea [:andreio]]

Somewhat confusing it's https://phabricator.services.mozilla.com/D54008 that needs to land in Beta. The other patch landed in Nightly. The two were not compatible but the change set is the same.

Comment 6

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9110319 [details]
Bug 1597706 - Remove the What's new toolbar badge message

Disable what's new panel, uplift approved for 71 beta 12, thanks.

Comment 7

[Raul Gurzau (:RaulG)]

FYI https://phabricator.services.mozilla.com/D53838 does not apply to beta:

Usage Exception:
Rebase onto ae3918d070fb9beee912d8b2c305df7093edc8b6 failed!

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

See comment 5 - D53838 wasn't supposed to land in beta.

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/131d053fd241

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e6eb852a8739

Comment 11

[Robert Martin [:romartin], Ecosystem QA]

I have verified that this issue is no longer reproducible using latest Firefox Beta (71.0b12 Build ID: 20191121155457) on Windows 10 x64, macOS 10.15, and Ubuntu 18.04 x64. I've created a new profile, waited ~5 minutes and can confirm that the "What's New" toolbar button, "What's New" toolbar badge, or the "What's New" toolbar "IMPRESSION" telemetry ping are not being displayed.