1597761 - Don't upload pings bigger than 1MB

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

As we do on Desktop, we need to add an upper bound to the maximum size of a ping that can be uploaded.

We can use the same boundary as Desktop: 1 MB.

Anything > 1MB should be discarded and we should record & report an error.

Comment 1

[Alessio Placitelli [:Dexter]]

Note: Mike put together a query that shows that the maximum we currently hit is 69kb.

Comment 2

[Alessio Placitelli [:Dexter]]

Let's wait for now, since we know all the pings we're sending and never got anything near that limit.

Comment 3

[Beatriz Rizental [:brizental]]

Adding this one to the milestone I am creating about ping uploading logic in glean-core.

Comment 4

[Beatriz Rizental [:brizental]]

Attachment: 1597761-data-review.md

Comment 5

[Chris H-C :chutten]

Comment on attachment 9156649 [details]
1597761-data-review.md

An individual must be named as responsible for permanent data collections.

Comment 6

[Chris H-C :chutten]

For clarification: the desktop 1MB limit is on the compressed ping size, not uncompressed. So pings > 1MB who compress < 1MB may be sent.

Not sure if Glean SDK wishes to adopt that approach as well.

Comment 7

[Beatriz Rizental [:brizental]]

Attachment: 1597761-data-review.md

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1098

Comment 9

[Chris H-C :chutten]

Comment on attachment 9166237 [details]
1597761-data-review.md

There is a new version of the data review form available that has an additional question (Q6) that needs to be answered (it's the one about the location of the documentation): https://github.com/mozilla/data-review/blob/master/request.md

Comment 10

[Beatriz Rizental [:brizental]]

Attachment: 1597761-data-review.md

I also removed the counter metric described in the previous data-reviews, as discussed in the PR.

Comment 11

[Chris H-C :chutten]

Comment on attachment 9166574 [details]
1597761-data-review.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Bea Rizental is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+