1597793 - Support tabs.onActivated

Status: RESOLVED FIXED

(GeckoView :: Extensions, enhancement, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

We should support tabs.onActivated maybe asking embedders to tell us which one is the current active tab with a new API like WebExtensionController.setActiveTab(GeckoSession session) or something like that.

This is used by some extensions to update the browser action popup.

The code today waits for a Fennec event which is never fired: https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/mobile/android/components/extensions/ext-tabs.js#117-130

mdn: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/onActivated

Comment 1

[Rob Wu [:robwu]]

The tabs API has more known defects with support for the active property, e.g. bug 1565536

Comment 2

[Christoph Walcher]

Attachment: Bug 1597793 - Support tabs.onActivated in GeckoView

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1597793 - Track tab activation in GeckoViewTab.

This avoids initialization issues with the previous approach.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1597793 - Don't return a tabId for non-tab windows.

If the window is a popup there is no WebExtension tab object present.

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1597793 - Use setTabActive in GVE.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1597793 - Check if a window is not a popup in ext-utils's onLocationChange.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b830ae752c93
Check if a window is not a popup in ext-utils's onLocationChange. r=snorp
https://hg.mozilla.org/integration/autoland/rev/0e9c04f18e3c
Support tabs.onActivated in GeckoView r=snorp,agi
https://hg.mozilla.org/integration/autoland/rev/4de3746c478e
Track tab activation in GeckoViewTab. r=snorp
https://hg.mozilla.org/integration/autoland/rev/79aaf28b5cea
Don't return a tabId for non-tab windows. r=snorp
https://hg.mozilla.org/integration/autoland/rev/d8132aa16234
Use setTabActive in GVE. r=snorp

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (bug 1597793) for ESlint error at GeckoViewWebExtension.jsm.
https://hg.mozilla.org/integration/autoland/rev/b1f2823f65c21e556230346eea1cf24c47f224da

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=d8132aa16234043252741d8c356665460cddf591&selectedJob=286450104

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286450104&repo=autoland&lineNumber=278

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/371b23a6a665
Check if a window is not a popup in ext-utils's onLocationChange. r=snorp
https://hg.mozilla.org/integration/autoland/rev/01769e564085
Support tabs.onActivated in GeckoView r=snorp,agi
https://hg.mozilla.org/integration/autoland/rev/bb84c78d3f3b
Track tab activation in GeckoViewTab. r=snorp
https://hg.mozilla.org/integration/autoland/rev/1aecf00f2b3b
Don't return a tabId for non-tab windows. r=snorp
https://hg.mozilla.org/integration/autoland/rev/5c1cbb543427
Use setTabActive in GVE. r=snorp

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/371b23a6a665
https://hg.mozilla.org/mozilla-central/rev/01769e564085
https://hg.mozilla.org/mozilla-central/rev/bb84c78d3f3b
https://hg.mozilla.org/mozilla-central/rev/1aecf00f2b3b
https://hg.mozilla.org/mozilla-central/rev/5c1cbb543427