1597822 - intl.l10n.pseudo = bidi doesn't bidi-ify all of the UI text

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[(no longer active)]

Attachment: intl.l10n.pseudo=bidi

Please see the screenshot, note how the text in the title of the active tab, new tab suggestions, or the Firefox menu appears normally.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: intl.uidirection=1

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: ar locale

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Three different modes that should create right-to-left experience.

The reference one is ar locale which represents the experience of using an Arabic locale (via langpack).

The two "pseudo" modes are intl.uidirection and intl.l10n.pseudo=bidi.

intl.uidirection seems to match the ar locale quite closely!

intl.l10n.pseudo differs in several areas:

• The arrows in the hamburger menu are in the wrong direction
• The urlbar placeholder is aligned to left instead of right
• The back/forward arrows in the urlbar are in the wrong direction
• Reload button is reversed
• The sidebar icons is reversed

I think that's all? If you see any other differences, please list them.

I believe the source of the diff is in two files that observe intl.uidirection but not intl.l10n.pseudo:

• https://searchfox.org/mozilla-central/source/dom/base/UIDirectionManager.cpp#51
• https://searchfox.org/mozilla-central/source/chrome/nsChromeRegistry.cpp#382

Let's fix that!

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1597822 - Hook up intl.l10n.pseudo in DOM/chrome.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: intl.l10n.pseudo.png

Here's the same screenshot as the original one from Ehsan, but with the patch applied.

I believe it fixes all noticed discrepancies.

Comment 6

[(no longer active)]

What about some of the text not being bidi-flipped?

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

Those are strings still using DTD/.properties. We're migrating them to Fluent.

Comment 8

[(no longer active)]

I see, thanks!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Jonathan - ping in case your phabricator queue is not reminding you about this r? :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/986ce7d1b67a
Hook up intl.l10n.pseudo in DOM/chrome. r=jfkthame

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/986ce7d1b67a

Comment 12

[Itiel]

Zibi, it seems that this is still an issue?
I thought maybe this regressed since it was fixed on November 26th so I ran mozregression but I got to November 25th and I still see this being an issue.

Am I missing something?

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

@Itiel - can you file a new bug with a screenshot and STR? I doubt this is the same issue. It may also be about strings that are not using Fluent yet.