Closed Bug 1597893 Opened 5 years ago Closed 5 years ago

convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: jeffinsam, Assigned: jeffinsam)

References

Details

Attachments

(1 file)

Bug 1597893 : convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Type: enhancement → task
Component: Untriaged → CSS Parsing and Computation
Product: Firefox → Core
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/726c8aa10d1a
convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio

Backed out changeset 726c8aa10d1a (Bug 1597893) for bustages complaining about nsCocoaWindow.h

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=726c8aa10d1adb136d41c1c2199ef0f9085234ff&tochange=76e20a306bc262843ec06d59c54416131af030cb&selectedJob=277412344

Backout link: https://hg.mozilla.org/integration/autoland/rev/76e20a306bc262843ec06d59c54416131af030cb

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277412344&repo=autoland&lineNumber=32487

[task 2019-11-21T12:35:50.016Z] 12:35:50 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/widget/cocoa'
[task 2019-11-21T12:35:50.018Z] 12:35:50 INFO - widget/cocoa/nsChildView.o
[task 2019-11-21T12:35:50.022Z] 12:35:50 INFO - /builds/worker/fetches/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-apple-darwin -o nsChildView.o -c -flto=thin -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/widget/cocoa -I/builds/worker/workspace/build/src/obj-firefox/widget/cocoa -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/media/platforms/apple -I/builds/worker/workspace/build/src/layout/base -I/builds/worker/workspace/build/src/layout/forms -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/widget -I/builds/worker/workspace/build/src/widget/headless -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -MD -MP -MF .deps/nsChildView.o.pp -flto=thin -x objective-c++ -fobjc-exceptions /builds/worker/workspace/build/src/widget/cocoa/nsChildView.mm
[task 2019-11-21T12:35:50.024Z] 12:35:50 INFO - In file included from /builds/worker/workspace/build/src/widget/cocoa/nsChildView.mm:15:
[task 2019-11-21T12:35:50.025Z] 12:35:50 ERROR - /builds/worker/workspace/build/src/widget/cocoa/nsCocoaWindow.h:297:37: error: unknown type name 'StyleWindowShadow'; did you mean 'mozilla::StyleWindowShadow'?
[task 2019-11-21T12:35:50.025Z] 12:35:50 INFO - virtual void SetWindowShadowStyle(StyleWindowShadow aStyle) override;
[task 2019-11-21T12:35:50.026Z] 12:35:50 INFO - ^~~~~~~~~~~~~~~~~
[task 2019-11-21T12:35:50.027Z] 12:35:50 INFO - mozilla::StyleWindowShadow
[task 2019-11-21T12:35:50.028Z] 12:35:50 INFO - /builds/worker/workspace/build/src/layout/style/nsStyleConsts.h:737:12: note: 'mozilla::StyleWindowShadow' declared here
[task 2019-11-21T12:35:50.029Z] 12:35:50 INFO - enum class StyleWindowShadow : uint8_t {
[task 2019-11-21T12:35:50.030Z] 12:35:50 INFO - ^
[task 2019-11-21T12:35:50.031Z] 12:35:50 INFO - 1 error generated.
[task 2019-11-21T12:35:50.031Z] 12:35:50 INFO - /builds/worker/workspace/build/src/config/rules.mk:792: recipe for target 'nsChildView.o' failed
[task 2019-11-21T12:35:50.032Z] 12:35:50 ERROR - make[4]: *** [nsChildView.o] Error 1
[task 2019-11-21T12:35:50.033Z] 12:35:50 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/widget/cocoa'
[task 2019-11-21T12:35:50.034Z] 12:35:50 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'widget/cocoa/target-objects' failed
[task 2019-11-21T12:35:50.035Z] 12:35:50 ERROR - make[3]: *** [widget/cocoa/target-objects] Error 2
[task 2019-11-21T12:35:50.036Z] 12:35:50 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-11-21T12:35:50.037Z] 12:35:50 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/layout/forms'
[task 2019-11-21T12:35:50.037Z] 12:35:50 INFO - layout/forms/Unified_cpp_layout_forms1.o
[task 2019-11-21T12:35:50.038Z] 12:35:50 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/layout/forms'

Flags: needinfo?(jeffinsam)
[task 2019-11-21T12:35:50.024Z] 12:35:50 INFO - In file included from /builds/worker/workspace/build/src/widget/cocoa/nsChildView.mm:15:
[task 2019-11-21T12:35:50.025Z] 12:35:50 ERROR - /builds/worker/workspace/build/src/widget/cocoa/nsCocoaWindow.h:297:37: error: unknown type name 'StyleWindowShadow'; did you mean 'mozilla::StyleWindowShadow'?
[task 2019-11-21T12:35:50.025Z] 12:35:50 INFO - virtual void SetWindowShadowStyle(StyleWindowShadow aStyle) override;
[task 2019-11-21T12:35:50.026Z] 12:35:50 INFO - ^~~~~~~~~~~~~~~~~
[task 2019-11-21T12:35:50.027Z] 12:35:50 INFO - mozilla::StyleWindowShadow
[task 2019-11-21T12:35:50.028Z] 12:35:50 INFO - /builds/worker/workspace/build/src/layout/style/nsStyleConsts.h:737:12: note: 'mozilla::StyleWindowShadow' declared here

The line causing problem was -

 /builds/worker/workspace/build/src/widget/cocoa/nsCocoaWindow.h:297:37: error: unknown type name 'StyleWindowShadow'; did you mean 'mozilla::StyleWindowShadow'?

I have made apt changes

But strangely enough, The build was successful in my local system, I didn't expect it to fail

I have also attached the build screen shot on my revision

Flags: needinfo?(jeffinsam)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dce49f743139
convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio
29090	12:44:49 ERROR - /builds/worker/workspace/build/src/widget/cocoa/nsCocoaWindow.mm:985:73: error: array subscript is not an integer
29093	12:44:49 ERROR - /builds/worker/workspace/build/src/widget/cocoa/nsCocoaWindow.mm:986:72: error: array subscript is not an integer

A casting was required, updated the revision

Flags: needinfo?(jeffinsam)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ffafa3ff2495
convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio

https://hg.mozilla.org/mozilla-central/rev/ffafa3ff2495

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → jeffinsam
Blocks: 1277133
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: