Closed Bug 1597910 Opened 5 years ago Closed 5 years ago

New tabs open in the background when using Shift+Cmd from Bookmarks Toolbar

Categories

(Firefox :: Bookmarks & History, enhancement)

70 Branch
x86_64
macOS
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: zoe.edwards86, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

Steps to reproduce:

Holding Shift + Command when pressing a link on the Bookmarks Toolbar.

Actual results:

The link opened in a new tab, but it was not the active/selected tab.

Expected results:

It should open a new tab, and make that tab the active/selected tab.

Perhaps this is just an opinion, but it mimics how links work on pages. It’s also how both Chrome 78 and Safari 13 work.

Enter about:preferences into the address bar. Is the When you open a link in a new tab, switch to it immediately option enabled or unchecked?

Open in Background Tab* 	command + Left-click link
Middle-click link
Open in Foreground Tab* 	command + Shift + Left-click
Shift + Middle-click
* The Open Foreground and Background Tab shortcuts will be switched if the "When I open a link in a new tab, switch to it immediately" setting is enabled
Component: Untriaged → Bookmarks & History
Flags: needinfo?(thomas.edwards)
OS: Unspecified → macOS
Hardware: Unspecified → x86_64
Summary: New tabs are not active when using Shift+Cmd from Bookmark Toolbar → New tabs open in the background when using Shift+Cmd from Bookmarks Toolbar

Just checked on two different Macs, it’s unticked on both. It works on links in pages, but no on the Bookmarks Toolbar.

Flags: needinfo?(thomas.edwards)

you may want to check and change the value of browser.tabs.loadBookmarksInBackground

Unfortunately the behavior was never harmonized across consumers, and now people got used to the existing behavior and may not want it to change.
Does the pref solve your troubles?

Flags: needinfo?(thomas.edwards)

Yup that’s perfect :mak, that does exactly what I would expect it to do by default, matches the behaviour of links in Firefox, and matches the behaviour of both Chrome and Safari.

I would really like to apply some pressure to make this the default behaviour though, seeing as it has (or seems to have) zero negative effects, so that people coming over from Chrome or Safari can do so with as little friction as possible.

Flags: needinfo?(thomas.edwards)

For now we cannot change the behavior because it looks like it would break muscle memory of users, we are re-evaluating the whole situation in bug 1536756, but it's complicate.
At least the pref is allowing to customize the handling as one prefers.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
See Also: → 1536756

To me this one seems pretty safe as:

Before

Cmd + Click = Open in new background tab
Shift + Cmd + Click = Open in new background tab (same)

After

Cmd + Click = Open in new background tab
Shift + Cmd + Click = Open in new foreground tab

So all that’s being applied is new functionality. The only people that would have to re-learn, are people holding down Shift when they press on a bookmark and expecting it to open in the background, which is the opposite of how links work on the page.

Hope you can resolve it all soon!

(In reply to Thomas Edwards from comment #6)

Before

Cmd + Click = Open in new background tab
Shift + Cmd + Click = Open in new background tab (same)

doesn't work like that for me on Windows, shift shoud invert the behavior, what I see is:
browser.tabs.loadBookmarksInBackground = false
Ctrl + Click = Open in new foreground tab
Shift + Ctrl + Click = Open in new background tab
browser.tabs.loadBookmarksInBackground = true
Ctrl + Click = Open in new background tab
Shift + Ctrl + Click = Open in new foreground tab
on the Mac Cmd should do the same as Ctrl.

If you see a different behavior there might be a bug

Man I’m super confused now 😅

browser.tabs.loadBookmarksInBackground = true

Click = Opens in current tab
Cmd + Click = Opens in background tab
Shift + Cmd + Click = Opens in foreground tab

browser.tabs.loadBookmarksInBackground = false (default)

Click = Opens in current tab
Cmd + Click = Opens in foreground tab
Shift + Cmd + Click = Opens in background tab

My expectation is that they work the same way as links on the page, as per Chrome and Safari, so I’m now using browser.tabs.loadBookmarksInBackground = true.

You need to log in before you can comment on or make changes to this bug.