1598007 - Copy Rules does not work anymore

Status: VERIFIED FIXED

(DevTools :: Inspector: Changes, defect, P1)

Description

[Patrick Brosset <:pbro>]

Steps:

• Open the Inspector on any page
• Make some CSS changes in the Rules panel
• Go to the Changes panel
• Click on the "Copy Rule" button after hovering on one of the changed rules' selector

Result: nothing gets copied to the clipboard and the following JS error is returned:

TypeError: this.inspector.inspectorFront.getAllInspectorFronts is not a function ChangesView.js:190:65

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1598007 - Fix exception when copying rules from the Changes panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cf12597dfa7
Fix exception when copying rules from the Changes panel. r=pbro

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5cf12597dfa7

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Managed to reproduce the issue using Fx72.0a1.
The issue is verified fixed using Fx72.0b11 and Fx73.0a1 on macOS 10.14, Ubuntu 18.04 and Windows 10 x64. The rules are correctly added to clipboard and no error message is displayed in the console.