1598138 - support static toolbar at top/bottom

Status: RESOLVED WONTFIX

(GeckoView :: General, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

To support static toolbar, we need to offset the client top position by the toolbar height and subtract the height from the GeckoView's height in GeckoSession.onWindowBoundsChanged().

To make the top toolbar dynamic, we can't simply offset the client rect at the same place, as far as I can tell, onBoundsChanged causes at least a reflow, we don't want to do that, we should tackle it in a different bug.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

One caveat here is that if GeckoView component isn't laid out in CoordinatorLayout, we don't need to worry about this issue, just like GeckoView exmaple which is in RelativeLayout component.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, for a static layout we really don't need to consider the toolbar at all. The viewport size will never change, so we don't need to do any special work here.

Comment 3

[Chris Peterson [:cpeterson]]

Moving toolbar bugs to the new GeckoView::Toolbar component.