159814 - New empty window/tab does not focus URL Bar when sys pref field is empty

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[james a]

When creating a new window, the default behaviour should be to highlight the URL
in the toolbar - this allows the user to start typing immediately, without
having to use the mouse to select the url or hitting command-L

Version 0.4

Comment 1

[Greg K.]

Nope, this works as it should. New *blank* windows focus the URL Bar, since the
user obviously needs to use it first.

However, new windows that automatically load a URL focus the content area, since
the user must want to use that page.

Comment 2

[saari (gone)]

greg is right, that is intended behavior (which had a long drawn out discussion
in the older mozilla days). marking invalid

Comment 3

[james a]

I'm not going to re-open the bug, but if I create a new window, it comes up as "about:blank" and the focus is on the (empty) window. The focus should be on the location bar.

I understand what you're saying with regards to opening windows that have a homepage set, but I have it set blank yet the focus is on the window.

I'm getting Chimera to respect the homepage prefs from the system preference pane, and the relevant field is empty in the system preferences.

Cheers

-- james

Comment 4

[Ben Lukens]

I'll confirm that if load home pages with new windows is on, use system prefs
for home page is on, and the system home page is blank, then a new window will
load about:blank, but the focus is on the blank content area. If you're not
using the system home page and your home page is blank, then new windows
correctly focus on the location bar.
That seems to be a valid bug.

Comment 5

[sairuh (rarely reading bugmail)]

i tried the test case in comment 4 with 2002.08.21.05 chimera bits, and it wfm
--focus is in the urlbar.

0. make sure chimera is not running.
1. set IC system pref to about:blank for home page.
2. start chimera. result: focus is in the urlbar, not the blank page content.
3. open a new window (cmd-N). result: focus is in the urlbar, not the blank page
content.

vrfying...

Comment 6

[james a]

I retested with Chimera 0.4. I still get this bug - I believe the reason that you did not come across it is because in Chimera's Navigation Preference panes, you must select "Use System Preference". If the IC preference homepage is set to blank, then whenever a new window is opened the focus is NOT on the URL bar.

Comment 7

[Sjoerd Bosga]

There is no problem when in System Preferences:Internet you manually enter
"about:blank" (without the quotes). However, when just clearing the homepage
field, System Preferences returns an empty string. This behaviour is different
from Chimera preferences: Chimera preferences returns "about:blank" in case the
homepage field is blank.

A simple fix is to check whether homePage is an empty string, and if so, set
homePage to "about:blank". I added a line to MainController.mm, and it worked
well. This is what the code with the fix looks like:
  // Now open the new window.
  NSString* homePage = mStartURL ? mStartURL : [mPreferenceManager homePage:YES];
  if ([homePage length]==0) homePage = @"about:blank";  // Catch for the case
where homePage is blank
  BrowserWindowController* controller = [self openBrowserWindowWithURL:homePage
andReferrer:nil];

  if ([homePage isEqualToString: @"about:blank"])
    [controller focusURLBar];
  else
    [[[controller getBrowserWrapper] getBrowserView] setActive: YES];

Comment 8

[Jim Garrison]

Should this bug block 55416 ([meta] Location bar focus issues)?

Comment 9

[saari (gone)]

->bryner, it lives! I think mozilla 1.3 is showing this behavior on windows, so
it might be several different regressions

Comment 10

[sairuh (rarely reading bugmail)]

clarifying summary --not a problem if the Navigation (camino) home page pref
field is empty. however, it's a problem if the Internet system pref is empty. wacky.

Comment 11

[sairuh (rarely reading bugmail)]

*** Bug 169995 has been marked as a duplicate of this bug. ***

Comment 12

[Jasper]

This issue is still reproducable in the 2003081002 NB.

Comment 13

[Ludovic Hirlimann [:Usul]]

This was fixed with bug 245359.