Land the DoH Rollout add-on into browser/extensions
Categories
(Firefox :: Security, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: maxx, Assigned: nhnt11)
References
Details
Attachments
(15 files, 2 obsolete files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Add DoH Rollout add-on to the browser/extensions
folder, along with a moz.build
file.
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D54617
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D54618
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D54619
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D54620
Assignee | ||
Comment 6•6 years ago
|
||
Depends on D54621
Assignee | ||
Comment 7•6 years ago
|
||
Depends on D54622
Assignee | ||
Comment 8•6 years ago
|
||
Depends on D54623
Assignee | ||
Comment 9•6 years ago
|
||
Depends on D54624
Assignee | ||
Comment 10•6 years ago
|
||
Depends on D54625
Assignee | ||
Comment 11•6 years ago
|
||
Depends on D54626
Assignee | ||
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Draft of moving to settings api for preferences. Not necessary to land system extension, but would be nice. Prefer someone take over and test.
Comment 13•6 years ago
|
||
Adding a system add-on requires coordinating with the gofaster folks to ensure that system addon update checks work correctly:
http://firefox-source-docs.mozilla.org/toolkit/mozapps/extensions/addon-manager/SystemAddons.html
Do you expect to ship updates to this? If not, does it need to be an extension at all? Most of the code here appears to run with chrome privileges, can this just be a jsm started from BrowserGlue.jsm?
Assignee | ||
Comment 14•6 years ago
|
||
(In reply to Andrew Swan [:aswan] from comment #13)
Adding a system add-on requires coordinating with the gofaster folks to ensure that system addon update checks work correctly:
http://firefox-source-docs.mozilla.org/toolkit/mozapps/extensions/addon-manager/SystemAddons.html
Thanks for the link! I'll do the due diligence.
Do you expect to ship updates to this? If not, does it need to be an extension at all? Most of the code here appears to run with chrome privileges, can this just be a jsm started from BrowserGlue.jsm?
This is the first step of a transition plan, the plan is to have a JSM at the end of the road. For now we are landing the add-on in-tree and moving development over to m-c from Github. This will be converted to a JSM asap (depending on prioritization).
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 15•6 years ago
•
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Assignee | ||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Try revealed that browser_preferences_usage.js fails due to an extra 4 (on my local macOS) accesses of the pref extensions.webextensions.default-content-security-policy
with my patches. Talked to mconley and came up with two workarounds:
- Use StaticPrefs for the webextension CSP prefs (try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf93be87c9937bea84644c0c253d23863b77a834)
- Bump the max allowed accesses of this pref in the test to 51 (try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9db8ecbdd3cccdf218e0af72f5ba08c240ca41b)
Assignee | ||
Comment 19•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 20•6 years ago
|
||
Static prefs route doesn't really work, can't add mirrored String prefs it seems.
Try push including talos jobs for bumping the max allowed accesses of this pref in the test to 51: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f110cb6744f61a1f5d0c8f346e2cd67340cc5f7
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Assignee | ||
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 25•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/289f65edbaea
https://hg.mozilla.org/mozilla-central/rev/ba3625505aa9
https://hg.mozilla.org/mozilla-central/rev/2e01f0052e3f
https://hg.mozilla.org/mozilla-central/rev/e7630c5ce7de
https://hg.mozilla.org/mozilla-central/rev/06baa550f86e
https://hg.mozilla.org/mozilla-central/rev/a076a3ddde96
https://hg.mozilla.org/mozilla-central/rev/7cc7fe778ae7
https://hg.mozilla.org/mozilla-central/rev/228ccf0ee453
https://hg.mozilla.org/mozilla-central/rev/b7bc6d796b8c
https://hg.mozilla.org/mozilla-central/rev/c82e86c51e6e
https://hg.mozilla.org/mozilla-central/rev/0878e4bac240
https://hg.mozilla.org/mozilla-central/rev/28ce51bf535d
https://hg.mozilla.org/mozilla-central/rev/0f1d580092b7
https://hg.mozilla.org/mozilla-central/rev/3fcb7b24eef8
https://hg.mozilla.org/mozilla-central/rev/3eca0e7441e2
Assignee | ||
Updated•6 years ago
|
Comment 26•6 years ago
|
||
(In reply to Nihanth Subramanya [:nhnt11] from comment #14)
Do you expect to ship updates to this? If not, does it need to be an extension at all? Most of the code here appears to run with chrome privileges, can this just be a jsm started from BrowserGlue.jsm?
This is the first step of a transition plan, the plan is to have a JSM at the end of the road. For now we are landing the add-on in-tree and moving development over to m-c from Github. This will be converted to a JSM asap (depending on prioritization).
Is there a follow-up bug for this effort?
Assignee | ||
Comment 27•6 years ago
|
||
There wasn't, but I filed bug 1603779. We're targeting 75 for this change. Thanks for following up on this!
Updated•5 years ago
|
Description
•