1598258 - Add the list of additional minidumps to the crashed plug-in events

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

Tests that need to cleanup crashes are currently forced to parse the .extra file to find out if more than one minidump was included in a crash. This is annoying because they sometimes race with the minidump-analyzer and there's no simple way of preventing it. Also parsing the file requires blocking I/O which makes the tests longer.

This issue can easily be solved by adding a field with the list of additional minidumps to the plugin-crashed event. This would both fix the races and simplify the test infrastructure dealing with them.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1598258 - Add a list of additional minidumps to the event delivered when a plug-in crashes r=froydnj

This patch adds a new field to the plugin-crashed event that holds the list
of additional minidumps associated with a crash report. The test
infrastructure is modified to use it which also fixes a race when processing
the .extra file. The reftest machinery has also been modified to take the new
field into account.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86dc639426da
Add a list of additional minidumps to the event delivered when a plug-in crashes r=froydnj

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/86dc639426da