1598278 - Service Workers can navigate out-of-scope clients

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P2)

Description

[Daniel Huigens [:twiss]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

1. Open https://out-of-scope-sw-navigation.glitch.me/test/
2. In another tab, open https://out-of-scope-sw-navigation.glitch.me/
3. In the first tab, click "Try to navigate"

This sends a request to the service worker (scoped to /test/) which then attempts to navigate the second client to /test/ as well.

Actual results:

The second tab is navigated. The service worker's console outputs:

[fetch event] https://out-of-scope-sw-navigation.glitch.me/test/navigate
scope: https://out-of-scope-sw-navigation.glitch.me/test/
controlled clients: Array [ WindowClient ]
all clients: Array [ WindowClient, WindowClient ]
navigated client to /test/

Expected results:

This navigation should not be allowed, as discussed in https://github.com/w3c/ServiceWorker/issues/752.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Link to failing tests:

• https://wpt.fyi/results/service-workers/service-worker/windowclient-navigate.https.html?label=experimental&label=master&aligned
• https://searchfox.org/mozilla-central/source/testing/web-platform/tests/service-workers/service-worker/windowclient-navigate.https.html

Comment 2

[Daniel Huigens [:twiss]]

Attachment: Bug 1598278 - Check that Service Worker controls client in navigate()

Comment 3

[Daniel Huigens [:twiss]]

Unfortunately, some of the above web platform tests are currently broken (the "NOTRUN" ones). I've submitted a PR here: https://github.com/web-platform-tests/wpt/pull/22063.

With that PR and the above patch, Firefox passes all tests.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Mark dependency on the WPT fix https://github.com/web-platform-tests/wpt/pull/22063 being synced to mozilla-central in bug 1619613.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a4dc0ad1266
Check that Service Worker controls client in navigate() r=asuth

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/3a4dc0ad1266

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Woo! Thanks so much for the fix!