Closed Bug 1598472 Opened 10 months ago Closed 10 months ago

MOZ_CRASH("Origin must be available when deserialized") impedes fuzzing

Categories

(Core :: DOM: Content Processes, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: haik, Assigned: haik)

References

(Depends on 1 open bug, )

Details

(Keywords: oss-fuzz, Whiteboard: sb?)

Attachments

(1 file)

Creating this bug to land a fix that #ifdefs around the MOZ_CRASH("Origin must be available when deserialized") in PrincipalInfoToPrincipal() when fuzzing is enabled. We still need to root cause bug 1578458.

+++ This bug was initially created as a clone of Bug #1578458 +++

When fuzzing, return an error instead of crashing in PrincipalInfoToPrincipal() for some error cases.

Assignee: nobody → haftandilian

@decoder, before landing this patch to help with fuzzing, I would like to validate that it does help with coverage. Are you able to help test fuzzing with the posted patch?

Flags: needinfo?(choller)

(In reply to Haik Aftandilian [:haik] from comment #2)

@decoder, before landing this patch to help with fuzzing, I would like to validate that it does help with coverage. Are you able to help test fuzzing with the posted patch?

Confirmed, this fixes the crash. I also took the liberty to fix bug 1591023 in a similar fashion for you. I will post the patch there for you to review. :)

Flags: needinfo?(choller)
Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4794696caa1
MOZ_CRASH("Origin must be available when deserialized") impedes fuzzing r=ckerschb
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Hi Haik, is qa needed here? If so, could you please provide us some steps? Thanks!

Flags: needinfo?(haftandilian)

(In reply to Catalin Sasca, QA [:csasca] from comment #6)

Hi Haik, is qa needed here? If so, could you please provide us some steps? Thanks!

No QA is needed for this. The changes are not compiled into release builds.

Flags: needinfo?(haftandilian)
Duplicate of this bug: 1450942
You need to log in before you can comment on or make changes to this bug.