1598472 - MOZ_CRASH("Origin must be available when deserialized") impedes fuzzing

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P1)

Description

[Haik Aftandilian [:haik]]

Creating this bug to land a fix that #ifdefs around the MOZ_CRASH("Origin must be available when deserialized") in PrincipalInfoToPrincipal() when fuzzing is enabled. We still need to root cause bug 1578458.

+++ This bug was initially created as a clone of Bug #1578458 +++

Comment 1

[Haik Aftandilian [:haik]]

Attachment: Bug 1598472 - MOZ_CRASH("Origin must be available when deserialized") impedes fuzzing

When fuzzing, return an error instead of crashing in PrincipalInfoToPrincipal() for some error cases.

Comment 2

[Haik Aftandilian [:haik]]

@decoder, before landing this patch to help with fuzzing, I would like to validate that it does help with coverage. Are you able to help test fuzzing with the posted patch?

Comment 3

[Christian Holler (:decoder)]

(In reply to Haik Aftandilian [:haik] from comment #2)

@decoder, before landing this patch to help with fuzzing, I would like to validate that it does help with coverage. Are you able to help test fuzzing with the posted patch?

Confirmed, this fixes the crash. I also took the liberty to fix bug 1591023 in a similar fashion for you. I will post the patch there for you to review. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4794696caa1
MOZ_CRASH("Origin must be available when deserialized") impedes fuzzing r=ckerschb

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f4794696caa1

Comment 6

[Catalin Sasca, Desktop QA [:csasca]]

Hi Haik, is qa needed here? If so, could you please provide us some steps? Thanks!

Comment 7

[Haik Aftandilian [:haik]]

(In reply to Catalin Sasca, QA [:csasca] from comment #6)

Hi Haik, is qa needed here? If so, could you please provide us some steps? Thanks!

No QA is needed for this. The changes are not compiled into release builds.