1598511 - Don't die if Subprocess can't chdir to workdir on OpenBSD

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[jcs]

Attachment: patch-toolkit_modules_subprocess_subprocess_worker_unix_js

With OpenBSD's veiled filesystem (see #1580271), the workdir of a Subprocess may not be visible, but the path to the actual executable being executed is.

In the case of 3rd party extensions like KeepassXC which need to execute /usr/local/bin/keepassxc-proxy, the Subprocess module sets a workdir of /usr/local/bin and then tries to chdir to it before executing. This fails on OpenBSD because Firefox doesn't have read access to /usr/local/bin, but it may (if the user added it) have access to execute /usr/local/bin/keepassxc-proxy.

So on OpenBSD, do not error if the chdir fails.

Comment 1

[Landry Breuil (:gaston)]

Comment on attachment 9110731 [details] [diff] [review]
patch-toolkit_modules_subprocess_subprocess_worker_unix_js

Who would be a good reviewer for that ?

Comment 2

[Landry Breuil (:gaston)]

:kmag, since this is your code, do you remember the need for the chdir() ?

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 9110731 [details] [diff] [review]
patch-toolkit_modules_subprocess_subprocess_worker_unix_js

I don't know this code so I can't help.

Comment 4

[Landry Breuil (:gaston)]

Andrew, any hint ? just so that we know if this is something that could go away on all platforms..

Comment 5

[Landry Breuil (:gaston)]

Attachment: Bug 1598511 - don't die if Subprocess can't chdir to workdir on OpenBSD

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b1e007558d2
don't die if Subprocess can't chdir to workdir on OpenBSD r=kmag

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6b1e007558d2

Comment 8

[Andrew Swan [:aswan]]

Looks like Kris addressed this over on Phabricator...

Comment 9

[Andrew McCreight [:mccr8]]

(In reply to Andrew Swan [:aswan] from comment #8)

Looks like Kris addressed this over on Phabricator...