Closed
Bug 1598531
Opened 5 years ago
Closed 5 years ago
Base Profiler logging is not synchronized with MOZ_LOG
Categories
(Core :: Gecko Profiler, task, P3)
Tracking
()
RESOLVED
FIXED
mozilla72
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
Details
Attachments
(1 file)
Base Profiler's LOG macros use simple printf (to stdout) to output their messages.
On top of potentially losing messages if the application crashes, messages may be printed later than those from MOZ_LOG.
We should fprintf to stderr instead.
|
Assignee | |
Comment 1•5 years ago
|
||
This is especially useful when debugging both Base Profiler and Gecko Profiler,
so that their messages are correctly sequenced.
Depends on D54446
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/407ccb5f316b Output Base Profiler logging to stderr, so it is correctly sync'd with MOZ_LOG - r=gregtatum
|
||
Comment 3•5 years ago
|
||
Backed out for causing MinGW bustages on GeckoProfiler.
Backout link: https://hg.mozilla.org/integration/autoland/rev/bf317b52fd44acd12845db1b4dc5d54bb3d08b4a
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=278302910&repo=autoland&lineNumber=80555
Flags: needinfo?(gsquelart)
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad4df3796e18 Output Base Profiler logging to stderr, so it is correctly sync'd with MOZ_LOG - r=gregtatum
|
|
Assignee | |
Updated•5 years ago
|
Flags: needinfo?(gsquelart)
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in
before you can comment on or make changes to this bug.
Description
•