1598613 - Speculative loader should respect the `media` attribute of the <link> tag

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Honza Bambas (:mayhemer)]

HTML link media Attribute
According to the speculative loader code we make requests for stylesheets that don't match the media criteria because the attribute is not at all consulted at the prescan phase.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598613 - Remove some useless kNamespaceID_Nones in HTMLLinkElement. r=hsivonen,edgar

Just drive-by clean-up, no behavior change.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598613 - Fix non-unified build in nsHtml5TreeOpExecutor.cpp. r=hsivonen,edgar

Just drive-by cleanup, no behavior change.

There's an using namespace mozilla, so also remove some useless
namespace qualifications while at it.

Depends on D103562

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Hah, I noticed the same bug looking at the code today.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598613 - Remove single-caller method in PreloadService. r=hsivonen,edgar

Just drive-by cleanup, no behavior change.

Depends on D103563

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598613 - Account for <link media=""> for speculative loads of stylesheet and preload links. r=hsivonen,edgar

<link media> applies to both <link rel="stylesheet"> (see
HTMLLinkElement::GetStyleSheetInfo) and all link rel="preload" links,
regardless of as value (see HTMLLinkElement::CheckPreloadAttrs), so pass it
down and check them for all of those cases.

Note that in the <link rel="stylesheet"> case we'd still have to load it, but
it doesn't block rendering and we defer its loading until more important
stylesheets are done (see SheetLoadData::ShouldDefer() which returns false if
the media attribute didn't match). So speculatively loading it seems
counter-productive.

Depends on D103564

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa8d88accd56
Remove some useless kNamespaceID_Nones in HTMLLinkElement. r=edgar
https://hg.mozilla.org/integration/autoland/rev/58e8fee8294f
Fix non-unified build in nsHtml5TreeOpExecutor.cpp. r=edgar
https://hg.mozilla.org/integration/autoland/rev/f77537699913
Remove single-caller method in PreloadService. r=edgar

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fa8d88accd56
https://hg.mozilla.org/mozilla-central/rev/58e8fee8294f
https://hg.mozilla.org/mozilla-central/rev/f77537699913

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dde9b51dd13b
Account for <link media=""> for speculative loads of stylesheet and preload links. r=hsivonen

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27422 for changes under testing/web-platform/tests

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dde9b51dd13b

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot