Closed Bug 1598683 Opened 5 months ago Closed 4 months ago

Add a way to enable conditional features in test262 shell tests

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

I'd like to turn on the shell test262 tests for FinalizationGroups on infra, but currently they require passing a command line option to enable them ('--enable-weak-ref').

The way this works for jit-tests is that we can use the |jit-test| header line in the test to pass the option and enable the feature. It would be great if there was a way to do this for jstests too but right now that doesn't seem to be the case.

There is a list of unsupported and conditionally supported features in tests/test262-update.py. The idea of this bug is to add a way to pass extra shell flags for certain features.

This is just for shell tests. For browser tests, configurable features are handled through tests/user.js which has a list of prefs to enable.

The patch adds a new reftest option that can be set in the |reftest| header to pass shell command line options. Annoyingly, the character sequence '--' is interpreted as the start of a comment so this must be stripped and re-added. The test262 update script now has a information about which shell options are need for each feature so the header option can be generated.

Jan do you think this is reasonable?

Priority: -- → P2
Blocks: 1600070
No longer blocks: 1561074
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93353c484ddc
Add a way to enable conditional features in test262 shell tests r=jandem
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.