1598684 - Clicking "Attach New File" in bugzilla is broken

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Miko Mynttinen]

Clicking "Attach New File" in bugzilla does nothing. Reproduced with Nightly 20191122091512 on macOS 10.14.

Mozregression indicates that this was regressed by bug 1551758.

10:52.58 INFO: Narrowed inbound regression window from [53119986, fa7c7f46] (3 builds) to [53119986, 1f77dd98] (2 builds) (~1 steps left)
10:52.58 INFO: No more inbound revisions, bisection finished.
10:52.59 INFO: Last good revision: 53119986f129bc2520e5ae25ba2a3096d2310036
10:52.59 INFO: First bad revision: 1f77dd98df61bb0b6c5ce53befbb98635fe4eed8
10:52.59 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53119986f129bc2520e5ae25ba2a3096d2310036&tochange=1f77dd98df61bb0b6c5ce53befbb98635fe4eed8

:jdai, could you take a look?

Comment 1

[John Dai[:jdai]]

Thank you for reporting this issue.

Comment 2

[John Dai[:jdai]]

It has a button element with button type under an a element with href. The problem is it shouldn't preventDefault to the button element with button type[1]. Should follow the spec[2] said do nothing.

[1] https://searchfox.org/mozilla-central/rev/3483fb259b4edbe4594cfcc3911db97d5441b67d/dom/html/HTMLButtonElement.cpp#261
[2] https://html.spec.whatwg.org/#attr-button-type-button-state

Comment 3

[John Dai[:jdai]]

Attachment: Bug 1598684 - Click button element with button type should do nothing;

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b41d10b907d5
Click button element with button type should do nothing; r=smaug

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b41d10b907d5

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

Managed to reproduce the issue on Fx72.0a1 buildID 20191122214053.
The issue is verified fixed using Fx73.0a1 and Fx72.0b11 on macOS 10.14, Ubuntu 18.04 and Windows 10 x64. The user is correctly redirected to the 'add new attachment' page without issues.