1598885 - Lightning no longer shows tasks due today in bold

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[Alain Knaff]

Up until now, lightning used to show tasks due today in a bold font in the list. This made it very easy to spot what is on the spot today.
However, now today's tasks are shown in the same font as the tasks further due in the future. Only tasks due in the past are shown differently, using a red font. Is there any way to get the old behavior back

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: task-list-style.png

Confirmed.

Comment 2

[Stefan Sitter [:ssitter]]

Richard, do you happen to know if this style change was done on purpose? If not, would it be suitable to restore this styling?

Screenshot shows a 2nd regression regarding styling: In both images no task is selected and focus is not within today pane. But in Tb 68 there is this blue focus rectangle that will always be displayed.

Comment 3

[Richard Marti (:Paenglab)]

It's not done on purpose AFAIK. maybe this is a regression from the de-XBL work. Because it's a tree, I can't inspect it to check what is set.

I don't see the 2nd regression locally. Again, trees aren't inspectable and the rectangle is normally shown when the treechildren has the attribute [current].

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1598885-task-duetoday.patch

Looked in the file history and found that I was the sinner in bug 1504190. :-(

Comment 5

[Paul Morris [:pmorris]]

Comment on attachment 9112044 [details] [diff] [review]
1598885-task-duetoday.patch

Review of attachment 9112044 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good, and I confirmed that tasks that are due today appear with bold text.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b56719530ba2
Re-add the rule for the duetoday tasks. r=pmorris

Comment 7

[Geoff Lankow (:darktrojan)]

73

Comment 8

[Geoff Lankow (:darktrojan)]

72 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/fcbccf3708d954c8ea1b258e2b392beb3a712b0a

Comment 9

[Geoff Lankow (:darktrojan)]

68.3.1:
https://hg.mozilla.org/releases/comm-esr68/rev/727518e6c1d94be0cca118ac17c9109f97592114