1598906 - Devtools incorrectly say that 'width' doesn't apply to table-rows

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Oriol Brufau [:Oriol]]

Attachment: testcase.html

Load attached testcase.

Inspect the row in devtools.

In the Rules panel, width: 100px is greyed out and it says

width has no effect on this element since it has a display of table-row.
Try adding display:inline-block* or display:block.

This is actually wrong, as you can see the row has a width of 100px, thanks to being in a vertical writing-mode.

Comment 1

[Oriol Brufau [:Oriol]]

And analogous for height in table-columns.

Comment 2

[Patrick Brosset <:pbro>]

Thanks for filing Oriol. The fix for this will need to happen in this file: https://searchfox.org/mozilla-central/source/devtools/server/actors/utils/inactive-property-helper.js

Comment 3

[Patrick Brosset <:pbro>]

Attachment: Bug 1598906 - Width and height shouldn't be marked as inactive on all table-rows; r?miker!

Width does not have an effect on a table-row element, but only when it is
displayed in a horizontal writing-mode.
Similarly, height does not have effect when it is displayed in a vertical
writing-mode.

So this patch makes our inactiveCSS validator a little more specific in those
cases.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56526c826c66
Width and height shouldn't be marked as inactive on all table-rows; r=miker

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/56526c826c66

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[(Out Sep 17-23) Ryan VanderMeulen]

Is this something you wanted to nominate for Beta uplift consideration or can this fix ride Fx74 to release?

Comment 8

[Patrick Brosset <:pbro>]

No need for an uplift for this one. Let's ride the trains with 74 and let it bake for a while there.