1598944 - Can't copy the innerHTML of a shadow root

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

If I inspect a shadow host and right-click on the #shadow-root, I cannot click on Copy > Inner HTML.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598944 - Allow to copy innerHTML of document fragments (including ShadowRoot). r=jdescottes

As they have an innerHTML property, and it is useful.

I didn't find relevant tests for this. browser_inspector-traversal.js tests only
the server bits.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598944 - Rename isSelectionElement to isElement in markup-context-menu.js. r=jdescottes

Depends on D54422

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598944 - Don't enable the "Delete" context menu for fragments. r=jdescottes

Right now it's enable but it throws with "remove() is not a function".

Depends on D55096

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598944 - Allow to paste innerHTML in fragments. r=jdescottes

No reason not to.

Depends on D55097

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1598944 - Test context menu in shadow root nodes. r=jdescottes

This covers all the previous changes, afaict.

Depends on D55098

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35d7fa762937
Allow to copy innerHTML of document fragments (including ShadowRoot). r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/f3986d8c8b24
Rename isSelectionElement to isElement in markup-context-menu.js. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6e91c5ac72a8
Don't enable the "Delete" context menu for fragments. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6030206a6a58
Allow to paste innerHTML in fragments. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/759b894614db
Test context menu in shadow root nodes. r=jdescottes

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/35d7fa762937
https://hg.mozilla.org/mozilla-central/rev/f3986d8c8b24
https://hg.mozilla.org/mozilla-central/rev/6e91c5ac72a8
https://hg.mozilla.org/mozilla-central/rev/6030206a6a58
https://hg.mozilla.org/mozilla-central/rev/759b894614db