1598974 - Watchpoint buttons are difficult to see when the object inspector property is highlighted

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[jaril]

Attachment: Screen Recording 2019-11-24 at 2.12.40 PM.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.97 Safari/537.36

Steps to reproduce:

1. Open http://janodvarko.cz/tests/debugger/watchpoints/
2. Click the button in Test Case #1, direction #2
3. Add a watchpoint (set/get) to the person's age property in the Scopes pane
4. Click on the age property to to highlight it

Actual results:

The watchpoint button (either set/get) blends into the highlighted background

Expected results:

The watchpoint button should stand out from the highlighted background

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Feels like a good first bug.

Honza

Comment 3

[Karntino Areros]

Attachment: Bug 1598974 - removes image opacity attribute and changes the color of the buttons.

Comment 4

[Karntino Areros]

Attachment: Bug 1598974 - removes image opacity attribute and changes the color of the buttons. r=Honza

Comment 5

[Karntino Areros]

Attachment: Bug 1598974 - removes image opacity attribute and changes the color of the buttons. r=Honza

Comment 6

[Karntino Areros]

Attachment: Bug 1598974 - slightly changes the color of the watchpoint markers when highlighted. r=Honza

Comment 7

[Karntino Areros]

I'm sorry, I've been making mistakes. I created new ones instead of updating the revision. Apologize for any confusion.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 9

[james]

Hey, what's the status of this bug, I would like to take this up if possible

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, please, thank you for the help

I think that the border of the watchpoint button should be white.
(and the background can use the same color as the highlight?)

Honza

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[Leslie]

Hi my name is Leslie and I'm an Outreachy applicant. Can I work on this bug?

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yes, thank you for helping.
Assigned to you.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 15

[Goodness Chris-Ugari]

Hi :Honza, I would like to work on this issue.

Comment 16

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thank you for helping.

Honza

Comment 17

[Goodness Chris-Ugari]

Attachment: Bug 1598974 - makes watchpoint markers' borders bolder. r?Jan Honza Odvarko

Comment 18

[Goodness Chris-Ugari]

:Honza, I made the watchpoint markers' borders bolder to make it more obvious when highlighted, tried to make the border white when highlighted but nothing seems to be working, any ideas?

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 20

[Akshya Krishnan]

Hello,
If this bug is still open, I would like to work on it please.

Comment 21

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Akshya Krishnan from comment #20)

Hello,
If this bug is still open, I would like to work on it please.

Hello Akshya, Goodness Chris-Ugari already had working patch for this that I forgot to land (but will try to today), sorry

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef7f28997097
slightly changes the color of the watchpoint markers when highlighted. r=nchevobbe

Comment 23

[Hubert Boma Manilla (:bomsy)]

Hi Akshya,
Are there other good first bugs you are interested in? You can check here for other good first bugshttps://codetribute.mozilla.org/projects/devtools?tag%3Dgood-first-bug

Comment 24

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ef7f28997097