Closed Bug 159901 Opened 19 years ago Closed 19 years ago
.cgi: localize strings send to message .html .tmpl (Part one)
Going to attach the first patch which moves most of the strings send to message.html.tmpl into messages.html.tmpl. As a plus I moves some title strings into the template. Still to do: Entangle the strings passed to Token.pm (send email) and to messages.html.tmpl + DisplayError strings.
This is great. A point for consideration here and in future templatisations of this sort - the error messages makes the error conditions rather self-documenting; when you move messages to the template, you may want to add a comment in the code explaining what the error is, if the error_tag is not explanatory enough. I'll review this later. Gerv
Also, one more point: if you plan to do a lot of these patches in the near future, open an umbrella bug, CC me, attach them all to the same bug, and _dont_ file review requests individually. This will help keep the spam down. Also, remember I'm away from Tuesday for nine days. Gerv
Comment on attachment 93136 [details] [diff] [review] v1: Patch token.cgi 2xr=gerv. Gerv
Attachment #93136 - Flags: review+
Fixed. Checking in token.cgi; /cvsroot/mozilla/webtools/bugzilla/token.cgi,v <-- token.cgi new revision: 1.9; previous revision: 1.8 done Checking in template/en/default/account/email/confirm.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/email/confirm.html.tmpl,v <-- confirm.html.tmpl new revision: 1.7; previous revision: 1.6 done Checking in template/en/default/account/password/set-forgotten-password.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/password/set-forgotten-password.html.tmpl,v <-- set-forgotten-password.html.tmpl new revision: 1.5; previous revision: 1.4 done Checking in template/en/default/global/messages.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl,v <-- messages.html.tmpl new revision: 1.2; previous revision: 1.1 done Gerv
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
19 years ago
Target Milestone: --- → Bugzilla 2.18
You need to log in before you can comment on or make changes to this bug.