1599101 - For clang-tidy based analysis add checker `clang-analyzer-cplusplus.Move`

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Andi [:andi]]

I think it's reasonable to add clang-analyzer-cplusplus.Move, in this way we will eliminate some of the issues like where we use an object after it's been moved.

Comment 1

[Andi [:andi]]

Let's make sure we don't regress: https://treeherder.mozilla.org/#/jobs?selectedJob=278017089&repo=try&revision=8d56be01d96ab4876a40678bcea23a81e6ae09e0

Comment 2

[Andi [:andi]]

Attachment: Bug 1599101 - For clang-tidy based analysis add checker `clang-analyzer-cplusplus.Move`. r=sylvestre

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Could you please report bugs to address the existing issues?
thanks

Comment 4

[Sylvestre Ledru [:Sylvestre]]

We have 5 occurrences of this defect in the code base for now.

Comment 5

[Simon Giesecke [:sg] [he/him]]

Where can we see the current defects? They are not in http://sylvestre.ledru.info/reports/fx-scan-build/ AFAIU.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Shared in private

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8861d7d25b12
For clang-tidy based analysis add checker `clang-analyzer-cplusplus.Move`. r=sylvestre

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8861d7d25b12